Skip to content

Conversation

sepandhaghighi
Copy link
Member

@sepandhaghighi sepandhaghighi commented May 16, 2025

Reference Issues/PRs

What does this implement/fix? Explain your changes.

  • functions.py renamed to utils.py
  • CLI functions moved to cli.py
  • IPv4 functions moved to ipv4.py

Any other comments?

@sepandhaghighi sepandhaghighi self-assigned this May 16, 2025
@sepandhaghighi sepandhaghighi added this to the ipspot v0.3 milestone May 16, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.70%. Comparing base (9649fdc) to head (cd9dda4).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev      #30   +/-   ##
=======================================
  Coverage   94.70%   94.70%           
=======================================
  Files           2        3    +1     
  Lines         151      151           
  Branches       15       15           
=======================================
  Hits          143      143           
  Misses          1        1           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sepandhaghighi sepandhaghighi marked this pull request as ready for review May 17, 2025 00:47
@sepandhaghighi
Copy link
Member Author

sepandhaghighi commented May 17, 2025

@sadrasabouri

Please review this PR! 💯
Additionally, consider the following:

  1. Test the CLI section manually
  2. The is_loopback function is a general utility that also works with IPv6, so I moved it to utils.py.

Copy link
Member

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, I also tested it locally on terminal and it's working as expected.

@sadrasabouri sadrasabouri merged commit e2ea1bc into dev May 17, 2025
21 checks passed
@sadrasabouri sadrasabouri deleted the refactor branch May 17, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants