Skip to content

Conversation

AHReccese
Copy link
Member

Reference Issues/PRs

#64

What does this implement/fix? Explain your changes.

Any other comments?

@AHReccese AHReccese added this to the ipspot v0.5 milestone Jul 22, 2025
@AHReccese AHReccese self-assigned this Jul 22, 2025
@AHReccese AHReccese added enhancement New feature or request ipv6 labels Jul 22, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.61%. Comparing base (6919bc9) to head (7172445).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev      #67   +/-   ##
=======================================
  Coverage   87.61%   87.61%           
=======================================
  Files           4        4           
  Lines         331      331           
  Branches       36       36           
=======================================
  Hits          290      290           
  Misses         24       24           
  Partials       17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AHReccese AHReccese linked an issue Jul 22, 2025 that may be closed by this pull request
@AHReccese AHReccese marked this pull request as ready for review July 25, 2025 00:54
@AHReccese AHReccese requested a review from sepandhaghighi July 25, 2025 00:54
@AHReccese
Copy link
Member Author

Hi Sepand, @sepandhaghighi
Could you please take a quick look at this PR? At the end of the ipv6 installation using warp, the allocated IPv6 address is now logged in the action log.

Does this behave as you intended?

Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AHReccese
Thank you for your efforts! 💯

One more thing we need to address in this PR is to limit the execution of test_ipv6.py to Linux only.

@AHReccese
Copy link
Member Author

AHReccese commented Jul 31, 2025

@AHReccese Thank you for your efforts! 💯

One more thing we need to address in this PR is to limit the execution of test_ipv6.py to Linux only.

Sure, I changed associated step to look like this:
(in order not to sacrifice the cohesiveness of this step, I didn't split it to toggling sub-steps)

- name: Test with pytest 
  run: |
    OS="${{ matrix.os }}"
    TEST_OS="${{ env.TEST_OS }}"
    if [[ "$OS" == "$TEST_OS" ]]; then
      python -m pytest . --cov=ipspot --cov-report=term
    else
      python -m pytest . --cov=ipspot --cov-report=term --ignore=tests/test_ipv6.py
    fi

@sepandhaghighi sepandhaghighi merged commit 74922f5 into dev Aug 1, 2025
6 of 22 checks passed
@sepandhaghighi sepandhaghighi deleted the ipv6 branch August 1, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request ipv6 test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: IPv6 Test

3 participants