Skip to content

Commit ed95e74

Browse files
authored
Fix possible bug within serialize_possible_ml_model function (#103)
* fix the usage of `upper` * remove `str` field from getting into `transporting` process
1 parent e415772 commit ed95e74

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

pymilo/chains/ensemble_chain.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,8 @@ def serialize_possible_ml_model(possible_ml_model):
118118
:type possible_ml_model: obj
119119
:return: tuple(bool, whether itself or dict)
120120
"""
121+
if isinstance(possible_ml_model, str):
122+
return False, possible_ml_model
121123
ml_category, transporter = get_transporter(possible_ml_model)
122124
if transporter is not None:
123125
return True, {

pymilo/chains/util.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,9 @@ def get_concrete_transporter(model):
2929
:return: tuple(ML_MODEL_CATEGORY, transporter function)
3030
"""
3131
if isinstance(model, str):
32-
if model.upper() in MODEL_TYPE_TRANSPORTER.keys():
33-
return model, MODEL_TYPE_TRANSPORTER[model]
32+
upper_model = model.upper()
33+
if upper_model in MODEL_TYPE_TRANSPORTER.keys():
34+
return upper_model, MODEL_TYPE_TRANSPORTER[upper_model]
3435

3536
if is_linear_model(model):
3637
return "LINEAR_MODEL", transport_linear_model

0 commit comments

Comments
 (0)