Skip to content

init/paper joss #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 41 commits into from
Jul 1, 2025
Merged

init/paper joss #211

merged 41 commits into from
Jul 1, 2025

Conversation

AHReccese
Copy link
Member

@AHReccese AHReccese commented Jun 3, 2025

Reference Issues/PRs

  • Prepare material for JOSS submission

What does this implement/fix? Explain your changes.

Any other comments?

@AHReccese
Copy link
Member Author

AHReccese commented Jun 3, 2025

I've fixed the action fail issue in another PR, I will rebase it after Sadra approves that.

Now we can work in parallel and fulfill our sections in this PR (as we previously divided on hack.md)

I spent a considerable time on the summary and Statement of the need parts, but still they are not the final version and I still need to tweak them a little bit more.

Please work on your parts and let me know if you need my contribution anywhere.

@sepandhaghighi
@sadrasabouri

@sadrasabouri
Copy link
Member

Hi @AHReccese, can you please break paragraphs into multi-lines? that way we can leave comments easier.

@AHReccese AHReccese requested a review from sepandhaghighi June 11, 2025 22:05
Add `@`, refactor sentence beginning
@AHReccese AHReccese requested a review from sadrasabouri June 25, 2025 16:52
@AHReccese AHReccese requested a review from sepandhaghighi June 26, 2025 17:25
@AHReccese
Copy link
Member Author

Dear Sepand, I've applied your feedback regarding doi.

Let me know if you have anything else to apply.

@AHReccese
Copy link
Member Author

@sepandhaghighi
I've replaced onnx and skops references with @software similiar to MontePy. PMML has it's own paper. Let me know if anything else is needed to be updated.

Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sepandhaghighi sepandhaghighi merged commit 47a6fcc into dev Jul 1, 2025
22 checks passed
@sepandhaghighi sepandhaghighi deleted the init/paper-joss branch July 1, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants