-
Notifications
You must be signed in to change notification settings - Fork 521
feat: Add Augmented Reality (AR) functionality. #513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
First of all, this is great work and I can see this being very useful for debugging and educational purposes. However this functionality is not helpful with primary goal of ibom as being an assembly documentation/helper tool. In fact tracking will likely not work reliably as the look of the board changes with components being added during assembly. Normally I would not object to useful functionality being added even if it is not directly helpful for assembly/documentation. But making this work is not straightforward and has serious usability concerns.
So I don't think this should be in main ibom package and I will not merge this at this point. A few pointers about how the issues can be fixed before I can revisit the decision to merge this upstream:
|
Hi @qu1ck, Thanks for your thoughtful feedback! I’ve actually been exploring those exact points:
Regarding use cases, I agree it’s more valuable during debugging than step‑by‑step assembly—hence why I chose to generate a final 3D-rendered image for the AR system, so it can track the board as it would appear when fully assembled. |
Do you have any fresh ideas for addressing point 2? Or maybe I could generate an auto-launch bash or somethings witch in the same path. |
You could generate a shell script (bat for windows) that will launch the server alongside the html file, like you said. It's still not ideal because it's not really portable but only other option is to generate actual python bundle executable which is an overkill. One more thing to note here, to be able to ship this plugin as a kicad addon all of it's python dependencies should be bundles with the code too. KiCad v9 new api supports pypi dependencies which it will automatically install in a dedicated virtual environment for each plugin but ibom is not yet ported to the new api. About mind files, generating images is half of the issue, converting it to .mind files is also cumbersome. Have you looked into porting the node lib that does the conversion to python? |
It seems that there is still no good way to start the web server. |
Ok, I'll pay attention to the python dependency issue. |
I have a new idea. Maybe we should modify the instructions for starting the server and teach users to manually add the file to the security exceptions so that they can use it directly through the file link. |
Does chrome allow that? Can you share steps for adding security exceptions? |
I have fully implemented the AR function.Here is a demonstration video.
But there are a few regrets: