Skip to content

Commit 243ba6a

Browse files
authored
Fix MetricAggregatorTests.testStarTreeDocValues (#18331)
Signed-off-by: Anthony Leong <aj.leong623@gmail.com>
1 parent 33e8155 commit 243ba6a

File tree

1 file changed

+14
-8
lines changed

1 file changed

+14
-8
lines changed

server/src/test/java/org/opensearch/search/aggregations/startree/MetricAggregatorTests.java

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,6 @@ protected Codec getCodec(
137137
return new Composite101Codec(Lucene101Codec.Mode.BEST_SPEED, mapperService, testLogger);
138138
}
139139

140-
@AwaitsFix(bugUrl = "https://github.com/opensearch-project/OpenSearch/issues/18110")
141140
public void testStarTreeDocValues() throws IOException {
142141
final List<Supplier<Integer>> MAX_LEAF_DOC_VARIATIONS = List.of(
143142
() -> 1,
@@ -563,18 +562,25 @@ public QueryBuilder getRangeQueryBuilder() {
563562

564563
public QueryBuilder getBoolQueryBuilder() {
565564
// MUST only
566-
BoolQueryBuilder mustOnly = new BoolQueryBuilder().must(getTermQueryBuilder()).must(getRangeQueryBuilder());
565+
BoolQueryBuilder mustOnly = new BoolQueryBuilder().must(getTermQueryBuilder());
566+
if (fieldType.equals(DimensionTypes.KEYWORD.name().toLowerCase(Locale.ROOT))) {
567+
mustOnly.must(getTermQueryBuilder());
568+
} else {
569+
mustOnly.must(getRangeQueryBuilder());
570+
}
567571

568572
// MUST with nested SHOULD on same dimension
569573
BoolQueryBuilder mustWithShould = new BoolQueryBuilder().must(getTermQueryBuilder())
570-
.must(
571-
new BoolQueryBuilder().should(new TermQueryBuilder(fieldName, valueSupplier.get()))
572-
.should(new TermQueryBuilder(fieldName, valueSupplier.get()))
573-
);
574+
.must(new BoolQueryBuilder().should(getTermQueryBuilder()).should(getTermQueryBuilder()));
574575

575576
// SHOULD only on same dimension
576-
BoolQueryBuilder shouldOnly = new BoolQueryBuilder().should(new TermQueryBuilder(fieldName, valueSupplier.get()))
577-
.should(new RangeQueryBuilder(fieldName).from(valueSupplier.get()).to(valueSupplier.get()));
577+
BoolQueryBuilder shouldOnly = new BoolQueryBuilder().should(getTermQueryBuilder());
578+
579+
if (fieldType.equals(DimensionTypes.KEYWORD.name().toLowerCase(Locale.ROOT))) {
580+
shouldOnly.should(getTermQueryBuilder());
581+
} else {
582+
shouldOnly.should(getRangeQueryBuilder());
583+
}
578584

579585
return randomFrom(mustOnly, mustWithShould, shouldOnly);
580586
}

0 commit comments

Comments
 (0)