Add condition to check JVM version for illegal-access switch (#5279)

adnapibar · reta · commit 391264169583 · 2023-10-30T12:41:02.000-04:00
This switch is removed in JDK version 17. https://openjdk.org/jeps/403 Signed-off-by: Rabi Panda <adnapibar@gmail.com>
diff --git a/buildSrc/src/main/java/org/opensearch/gradle/OpenSearchTestBasePlugin.java b/buildSrc/src/main/java/org/opensearch/gradle/OpenSearchTestBasePlugin.java
@@ -111,7 +111,9 @@ public void execute(Task t) {
                         test.systemProperty("java.locale.providers", "SPI,JRE");
                     } else {
                         test.systemProperty("java.locale.providers", "SPI,COMPAT");
-                        test.jvmArgs("--illegal-access=warn");
+                        if (test.getJavaVersion().compareTo(JavaVersion.VERSION_17) < 0) {
+                            test.jvmArgs("--illegal-access=warn");
+                        }
                     }
                 }
             });

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,9 @@ public void execute(Task t) {`
`111`	`111`	`test.systemProperty("java.locale.providers", "SPI,JRE");`
`112`	`112`	`} else {`
`113`	`113`	`test.systemProperty("java.locale.providers", "SPI,COMPAT");`
`114`		`- test.jvmArgs("--illegal-access=warn");`
	`114`	`+ if (test.getJavaVersion().compareTo(JavaVersion.VERSION_17) < 0) {`
	`115`	`+ test.jvmArgs("--illegal-access=warn");`
	`116`	`+ }`
`115`	`117`	`}`
`116`	`118`	`}`
`117`	`119`	`});`