Skip to content

Commit 64be0ab

Browse files
authored
Change noisy logs on SegRep and remote store paths to trace level (#9323)
Signed-off-by: Marc Handalian <handalm@amazon.com>
1 parent c6b67e1 commit 64be0ab

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

server/src/main/java/org/opensearch/index/shard/IndexShard.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1641,20 +1641,20 @@ public Tuple<GatedCloseable<SegmentInfos>, ReplicationCheckpoint> getLatestSegme
16411641
*/
16421642
public boolean isSegmentReplicationAllowed() {
16431643
if (indexSettings.isSegRepEnabled() == false) {
1644-
logger.warn("Attempting to perform segment replication when it is not enabled on the index");
1644+
logger.trace("Attempting to perform segment replication when it is not enabled on the index");
16451645
return false;
16461646
}
16471647
if (getReplicationTracker().isPrimaryMode()) {
1648-
logger.warn("Shard is in primary mode and cannot perform segment replication as a replica.");
1648+
logger.trace("Shard is in primary mode and cannot perform segment replication as a replica.");
16491649
return false;
16501650
}
16511651
if (this.routingEntry().primary()) {
1652-
logger.warn("Shard routing is marked primary thus cannot perform segment replication as replica");
1652+
logger.trace("Shard routing is marked primary thus cannot perform segment replication as replica");
16531653
return false;
16541654
}
16551655
if (state().equals(IndexShardState.STARTED) == false
16561656
&& (state() == IndexShardState.POST_RECOVERY && shardRouting.state() == ShardRoutingState.INITIALIZING) == false) {
1657-
logger.warn(
1657+
logger.trace(
16581658
() -> new ParameterizedMessage(
16591659
"Shard is not started or recovering {} {} and cannot perform segment replication as a replica",
16601660
state(),
@@ -1664,7 +1664,7 @@ public boolean isSegmentReplicationAllowed() {
16641664
return false;
16651665
}
16661666
if (getReplicationEngine().isEmpty()) {
1667-
logger.warn(
1667+
logger.trace(
16681668
() -> new ParameterizedMessage(
16691669
"Shard does not have the correct engine type to perform segment replication {}.",
16701670
getEngine().getClass()
@@ -4815,8 +4815,8 @@ private String copySegmentFiles(
48154815
}
48164816
}
48174817
} finally {
4818-
logger.info("Downloaded segments here: {}", downloadedSegments);
4819-
logger.info("Skipped download for segments here: {}", skippedSegments);
4818+
logger.trace("Downloaded segments here: {}", downloadedSegments);
4819+
logger.trace("Skipped download for segments here: {}", skippedSegments);
48204820
}
48214821
return segmentNFile;
48224822
}

server/src/main/java/org/opensearch/index/shard/RemoteStoreRefreshListener.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ private boolean shouldSync(boolean didRefresh) {
189189

190190
private boolean syncSegments() {
191191
if (indexShard.getReplicationTracker().isPrimaryMode() == false || indexShard.state() == IndexShardState.CLOSED) {
192-
logger.info(
192+
logger.trace(
193193
"Skipped syncing segments with primaryMode={} indexShardState={}",
194194
indexShard.getReplicationTracker().isPrimaryMode(),
195195
indexShard.state()

server/src/main/java/org/opensearch/index/store/RemoteSegmentStoreDirectory.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ public RemoteSegmentMetadata readLatestMetadataFile() throws IOException {
200200
logger.trace("Reading latest Metadata file {}", latestMetadataFile);
201201
remoteSegmentMetadata = readMetadataFile(latestMetadataFile);
202202
} else {
203-
logger.info("No metadata file found, this can happen for new index with no data uploaded to remote segment store");
203+
logger.trace("No metadata file found, this can happen for new index with no data uploaded to remote segment store");
204204
}
205205

206206
return remoteSegmentMetadata;
@@ -786,7 +786,7 @@ public void deleteStaleSegments(int lastNMetadataFilesToKeep) throws IOException
786786
Integer.MAX_VALUE
787787
);
788788
if (sortedMetadataFileList.size() <= lastNMetadataFilesToKeep) {
789-
logger.info(
789+
logger.trace(
790790
"Number of commits in remote segment store={}, lastNMetadataFilesToKeep={}",
791791
sortedMetadataFileList.size(),
792792
lastNMetadataFilesToKeep
@@ -849,7 +849,7 @@ public void deleteStaleSegments(int lastNMetadataFilesToKeep) throws IOException
849849
}
850850
});
851851
if (deletionSuccessful.get()) {
852-
logger.info("Deleting stale metadata file {} from remote segment store", metadataFile);
852+
logger.trace("Deleting stale metadata file {} from remote segment store", metadataFile);
853853
remoteMetadataDirectory.deleteFile(metadataFile);
854854
}
855855
}

0 commit comments

Comments
 (0)