Defer ITs

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>

Author: ltaragi

server/src/internalClusterTest/java/org/opensearch/remotemigration/RemoteStoreMigrationShardAllocationBaseTestCase.java

@@ -8,29 +8,20 @@
 
 package org.opensearch.remotemigration;
 
-import org.opensearch.action.admin.cluster.allocation.ClusterAllocationExplanation;
 import org.opensearch.action.admin.cluster.settings.ClusterUpdateSettingsRequest;
 import org.opensearch.action.admin.cluster.snapshots.restore.RestoreSnapshotResponse;
-import org.opensearch.action.support.ActiveShardCount;
 import org.opensearch.cluster.metadata.IndexMetadata;
 import org.opensearch.cluster.node.DiscoveryNode;
 import org.opensearch.cluster.node.DiscoveryNodes;
 import org.opensearch.cluster.routing.IndexShardRoutingTable;
 import org.opensearch.cluster.routing.ShardRouting;
-import org.opensearch.cluster.routing.ShardRoutingState;
-import org.opensearch.cluster.routing.allocation.AllocateUnassignedDecision;
-import org.opensearch.cluster.routing.allocation.MoveDecision;
-import org.opensearch.cluster.routing.allocation.NodeAllocationResult;
-import org.opensearch.cluster.routing.allocation.decider.Decision;
-import org.opensearch.common.Nullable;
 import org.opensearch.common.settings.Settings;
 import org.opensearch.core.rest.RestStatus;
 import org.opensearch.index.IndexSettings;
 import org.opensearch.indices.replication.common.ReplicationType;
 import org.opensearch.snapshots.SnapshotInfo;
 import org.opensearch.snapshots.SnapshotState;
 
-import java.util.List;
 import java.util.Map;
 import java.util.Optional;
 
@@ -56,7 +47,7 @@ protected void setClusterMode(String mode) {
     }
 
     // set the migration direction for cluster [remote_store, docrep, none]
-    protected void setDirection(String direction) {
+    public void setDirection(String direction) {
         updateSettingsRequest.persistentSettings(Settings.builder().put(MIGRATION_DIRECTION_SETTING.getKey(), direction));
         assertAcked(internalCluster().client().admin().cluster().updateSettings(updateSettingsRequest).actionGet());
     }
@@ -88,7 +79,7 @@ protected String allNodesExcept(String except) {
         return exclude.toString();
     }
 
-    // create a new test index with un-allocated primary and no replicas
+    // create a new test index
     protected void prepareIndexWithoutReplica(Optional<String> name) {
         String indexName = name.orElse(TEST_INDEX);
         internalCluster().client()
@@ -105,33 +96,6 @@ protected void prepareIndexWithoutReplica(Optional<String> name) {
             .actionGet();
     }
 
-    // create a new test index with allocated primary and 1 unallocated replica
-    public void prepareIndexWithAllocatedPrimary(DiscoveryNode primaryShardNode, Optional<String> name) {
-        String indexName = name.orElse(TEST_INDEX);
-        internalCluster().client()
-            .admin()
-            .indices()
-            .prepareCreate(indexName)
-            .setSettings(
-                Settings.builder()
-                    .put("index.number_of_shards", 1)
-                    .put("index.number_of_replicas", 1)
-                    .put("index.routing.allocation.include._name", primaryShardNode.getName())
-                    .put("index.routing.allocation.exclude._name", allNodesExcept(primaryShardNode.getName()))
-            )
-            .setWaitForActiveShards(ActiveShardCount.ONE)
-            .execute()
-            .actionGet();
-
-        ensureYellowAndNoInitializingShards(TEST_INDEX);
-
-        logger.info(" --> verify allocation of primary shard");
-        assertAllocation(true, primaryShardNode);
-
-        logger.info(" --> verify non-allocation of replica shard");
-        assertNonAllocation(false);
-    }
-
     protected ShardRouting getShardRouting(boolean isPrimary) {
         IndexShardRoutingTable table = internalCluster().client()
             .admin()
@@ -146,108 +110,6 @@ protected ShardRouting getShardRouting(boolean isPrimary) {
         return (isPrimary ? table.primaryShard() : table.replicaShards().get(0));
     }
 
-    // obtain decision for allocation/relocation of a shard to a given node
-    protected Decision getDecisionForTargetNode(
-        DiscoveryNode targetNode,
-        boolean isPrimary,
-        boolean includeYesDecisions,
-        boolean isRelocation
-    ) {
-        ClusterAllocationExplanation explanation = internalCluster().client()
-            .admin()
-            .cluster()
-            .prepareAllocationExplain()
-            .setIndex(TEST_INDEX)
-            .setShard(0)
-            .setPrimary(isPrimary)
-            .setIncludeYesDecisions(includeYesDecisions)
-            .get()
-            .getExplanation();
-
-        Decision requiredDecision = null;
-        List<NodeAllocationResult> nodeAllocationResults;
-        if (isRelocation) {
-            MoveDecision moveDecision = explanation.getShardAllocationDecision().getMoveDecision();
-            nodeAllocationResults = moveDecision.getNodeDecisions();
-        } else {
-            AllocateUnassignedDecision allocateUnassignedDecision = explanation.getShardAllocationDecision().getAllocateDecision();
-            nodeAllocationResults = allocateUnassignedDecision.getNodeDecisions();
-        }
-
-        for (NodeAllocationResult nodeAllocationResult : nodeAllocationResults) {
-            if (nodeAllocationResult.getNode().equals(targetNode)) {
-                for (Decision decision : nodeAllocationResult.getCanAllocateDecision().getDecisions()) {
-                    if (decision.label().equals(NAME)) {
-                        requiredDecision = decision;
-                        break;
-                    }
-                }
-            }
-        }
-
-        assertNotNull(requiredDecision);
-        return requiredDecision;
-    }
-
-    // get allocation and relocation decisions for all nodes
-    protected void prepareDecisions() {
-        internalCluster().client()
-            .admin()
-            .indices()
-            .prepareUpdateSettings(TEST_INDEX)
-            .setSettings(Settings.builder().put("index.routing.allocation.exclude._name", allNodesExcept(null)))
-            .execute()
-            .actionGet();
-    }
-
-    protected void attemptAllocation(@Nullable String targetNodeName) {
-        Settings.Builder settingsBuilder;
-        if (targetNodeName != null) {
-            settingsBuilder = Settings.builder()
-                .put("index.routing.allocation.include._name", targetNodeName)
-                .put("index.routing.allocation.exclude._name", allNodesExcept(targetNodeName));
-        } else {
-            String clusterManagerNodeName = internalCluster().client()
-                .admin()
-                .cluster()
-                .prepareState()
-                .execute()
-                .actionGet()
-                .getState()
-                .getNodes()
-                .getClusterManagerNode()
-                .getName();
-            // to allocate freely among all nodes other than cluster-manager node
-            settingsBuilder = Settings.builder()
-                .put("index.routing.allocation.include._name", allNodesExcept(clusterManagerNodeName))
-                .put("index.routing.allocation.exclude._name", clusterManagerNodeName);
-        }
-        internalCluster().client().admin().indices().prepareUpdateSettings(TEST_INDEX).setSettings(settingsBuilder).execute().actionGet();
-    }
-
-    // verify that shard does not exist at targetNode
-    protected void assertNonAllocation(boolean isPrimary) {
-        if (isPrimary) {
-            ensureRed(TEST_INDEX);
-        } else {
-            ensureYellowAndNoInitializingShards(TEST_INDEX);
-        }
-        ShardRouting shardRouting = getShardRouting(isPrimary);
-        assertFalse(shardRouting.active());
-        assertNull(shardRouting.currentNodeId());
-        assertEquals(ShardRoutingState.UNASSIGNED, shardRouting.state());
-    }
-
-    // verify that shard exists at targetNode
-    protected void assertAllocation(boolean isPrimary, @Nullable DiscoveryNode targetNode) {
-        ShardRouting shardRouting = getShardRouting(isPrimary);
-        assertTrue(shardRouting.active());
-        assertNotNull(shardRouting.currentNodeId());
-        if (targetNode != null) {
-            assertEquals(shardRouting.currentNodeId(), targetNode.getId());
-        }
-    }
-
     // create a snapshot
     public static SnapshotInfo createSnapshot(String snapshotRepoName, String snapshotName, String... indices) {
         SnapshotInfo snapshotInfo = internalCluster().client()
@@ -332,5 +194,4 @@ public static void assertRemoteStoreBackedIndex(String indexName) {
             INDEX_REMOTE_TRANSLOG_BUFFER_INTERVAL_SETTING.get(indexSettings)
         );
     }
-
 }