Skip to content

Commit cb591e0

Browse files
committed
add volatile to variable
Signed-off-by: kkewwei <kewei.11@bytedance.com>
1 parent f49ca69 commit cb591e0

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

server/src/main/java/org/opensearch/indices/IndicesQueryCache.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -158,9 +158,6 @@ public IndicesQueryCache(Settings settings, ClusterSettings clusterSettings) {
158158
}
159159

160160
public void setSkipCacheFactor(float skipCacheFactor) {
161-
if (skipCacheFactor < 1) {
162-
throw new IllegalArgumentException("skipCacheFactor must be no less than 1, get " + skipCacheFactor);
163-
}
164161
logger.debug(
165162
"set cluster settings {} {} -> {}",
166163
INDICES_QUERIES_CACHE_SKIP_CACHE_FACTOR.getKey(),
@@ -455,8 +452,8 @@ protected void onMiss(Object readerCoreKey, Query filter) {
455452
* Custom caching policy for Opensearch.
456453
*/
457454
public static class OpenseachUsageTrackingQueryCachingPolicy extends UsageTrackingQueryCachingPolicy {
458-
private int minFrequency;
459-
private int minFrequencyForCostly;
455+
private volatile int minFrequency;
456+
private volatile int minFrequencyForCostly;
460457

461458
public OpenseachUsageTrackingQueryCachingPolicy(ClusterSettings clusterSettings) {
462459
minFrequency = clusterSettings.get(INDICES_QUERY_CACHE_MIN_FREQUENCY);

0 commit comments

Comments
 (0)