Skip to content

[AUTOCUT] Gradle Check Flaky Test Report for SearchIT #18129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
opensearch-ci-bot opened this issue Apr 29, 2025 · 5 comments · Fixed by #18212 · May be fixed by #18367
Open

[AUTOCUT] Gradle Check Flaky Test Report for SearchIT #18129

opensearch-ci-bot opened this issue Apr 29, 2025 · 5 comments · Fixed by #18212 · May be fixed by #18367
Assignees
Labels
autocut flaky-test Random test failure that succeeds on second run >test-failure Test failure from CI, local build, etc. untriaged

Comments

@opensearch-ci-bot
Copy link
Collaborator

opensearch-ci-bot commented Apr 29, 2025

Flaky Test Report for SearchIT

Noticed the SearchIT has some flaky, failing tests that failed during post-merge actions.

Details

Git Reference Merged Pull Request Build Details Test Name
22a6194 18124 58554 org.opensearch.client.SearchIT.testSearchWithMatrixStats
2c1b2aa 18247 57899 org.opensearch.client.SearchIT.testSearchWithMatrixStats
83a4beb 18073 57316 org.opensearch.client.SearchIT.testSearchWithMatrixStats

The other pull requests, besides those involved in post-merge actions, that contain failing tests with the SearchIT class are:

For more details on the failed tests refer to OpenSearch Gradle Check Metrics dashboard.

@opensearch-ci-bot opensearch-ci-bot added >test-failure Test failure from CI, local build, etc. autocut flaky-test Random test failure that succeeds on second run untriaged labels Apr 29, 2025
@andrross
Copy link
Member

andrross commented Apr 29, 2025

REPRODUCE WITH: ./gradlew ':client:rest-high-level:asyncIntegTest' --tests "org.opensearch.client.SearchIT.testSearchWithMatrixStats" -Dtests.seed=630A15BDCB6BB5D9 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ksb -Dtests.timezone=Europe/Jersey -Druntime.java=21

SearchIT > testSearchWithMatrixStats FAILED
    java.lang.AssertionError: expected:<1830.0000000000002> but was:<1829.9999999999998>
        at __randomizedtesting.SeedInfo.seed([630A15BDCB6BB5D9:1301905AE5084B97]:0)
        at org.junit.Assert.fail(Assert.java:89)
        at org.junit.Assert.failNotEquals(Assert.java:835)
        at org.junit.Assert.assertEquals(Assert.java:555)
        at org.junit.Assert.assertEquals(Assert.java:685)
        at org.opensearch.client.SearchIT.testSearchWithMatrixStats(SearchIT.java:570)

Looks like this test is expecting a very specific value here:

assertEquals(1830.0000000000002, matrixStats.getVariance("num"), 0d);

@andrross
Copy link
Member

#17978 could be the cause here. @bowenlan-amzn @sohami @Vikasht34 This is a newly flaky test. Would concurrent search by default explain the issue here?

@bowenlan-amzn
Copy link
Member

@andrross I will look into this
We did see issue of small mismatch of matrx stats agg and add tolerance for that 4a92aa4

@bowenlan-amzn bowenlan-amzn self-assigned this Apr 29, 2025
@dbwiddis
Copy link
Member

dbwiddis commented May 5, 2025

I'm seeing this flaky a lot on my unrelated PR(s).

java.lang.AssertionError: expected:<1830.0000000000002> but was:<1830.0>
java.lang.AssertionError: expected:<1830.0000000000002> but was:<1830.0000000000005>

There are several tests which provide a 0d tolerance interval.

@kkewwei
Copy link
Collaborator

kkewwei commented May 28, 2025

@bowenlan-amzn Could you mind have a look in your spare time?

@bowenlan-amzn bowenlan-amzn reopened this May 28, 2025
@github-project-automation github-project-automation bot moved this from Done to In Progress in Performance Roadmap May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut flaky-test Random test failure that succeeds on second run >test-failure Test failure from CI, local build, etc. untriaged
Projects
Status: In Progress
5 participants