Fix flaky test RemoteSegmentTransferTrackerTests.testGetInflightUploadBytes

[sachinpkale]

Description

• In RemoteSegmentTransferTrackerTests.testGetInflightUploadBytes, we get random value for started, succeeded and failed bytes with following logic:
  

  OpenSearch/server/src/test/java/org/opensearch/index/remote/RemoteSegmentTransferTrackerTests.java

  Lines 261 to 263 in 46f852a

  	long bytesStarted = randomLongBetween(10000, 100000);
  	long bytesSucceeded = randomLongBetween(1000, 10000);
  	long bytesFailed = randomLongBetween(100, 1000);

• Here, the expectation is, started >= failed + succeeded. We assert with following check:
  

  OpenSearch/server/src/main/java/org/opensearch/index/remote/RemoteTransferTracker.java

  Lines 257 to 268 in 46f852a

  	private void checkTotal(long startedCount, long failedCount, long succeededCount, long countToAdd) {
  	long delta = startedCount - (failedCount + succeededCount + countToAdd);
  	assert delta >= 0 : "Sum of failure count ("
  	+ failedCount
  	+ "), success count ("
  	+ succeededCount
  	+ "), and count to add ("
  	+ countToAdd
  	+ ") cannot exceed started count ("
  	+ startedCount
  	+ ")";
  	}

• But while assigning random value, it is possible to assign following values which breaks the above assertion:

  • started = 10200
  • succeeded = 9900
  • failed = 8000

• To make sure the assertion never fails, in this PR, we change the lower bound of started to 12000.

Related Issues

• [AUTOCUT] Gradle Check Flaky Test Report for RemoteSegmentTransferTrackerTests #14325

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

✅ Gradle check result for d5589dd: SUCCESS

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.27%. Comparing base (931c1aa) to head (d5589dd).
Report is 7 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #17128      +/-   ##
============================================
- Coverage     72.30%   72.27%   -0.04%     
+ Complexity    65482    65459      -23     
============================================
  Files          5309     5309              
  Lines        304324   304347      +23     
  Branches      44132    44141       +9     
============================================
- Hits         220056   219966      -90     
- Misses        66259    66333      +74     
- Partials      18009    18048      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.