Skip to content

Avoid invalid retries on multiple replicas when querying #17370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025

Conversation

kkewwei
Copy link
Contributor

@kkewwei kkewwei commented Feb 16, 2025

Description

Related Issues

Resolves #17361

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for f235073: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei
Copy link
Contributor Author

kkewwei commented Feb 16, 2025

❌ Gradle check result for f235073: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

MetadataCreateIndexServiceTests.testCreateIndexWithContextDisabled #17291

Copy link
Contributor

github-actions bot commented Mar 8, 2025

❌ Gradle check result for 628a905: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Apr 19, 2025
@opensearch-trigger-bot opensearch-trigger-bot bot removed the stalled Issues that have stalled label Apr 21, 2025
Copy link
Contributor

❌ Gradle check result for 17c923f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 17c923f: SUCCESS

Copy link

codecov bot commented Apr 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.50%. Comparing base (54e02a7) to head (26c727e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17370      +/-   ##
============================================
+ Coverage     72.47%   72.50%   +0.02%     
- Complexity    67034    67104      +70     
============================================
  Files          5478     5478              
  Lines        310132   310141       +9     
  Branches      45087    45090       +3     
============================================
+ Hits         224775   224864      +89     
+ Misses        66960    66913      -47     
+ Partials      18397    18364      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: kkewwei <kewei.11@bytedance.com>
Signed-off-by: kkewwei <kkewwei@163.com>
@kkewwei kkewwei force-pushed the avoid_invalid_query branch from 17c923f to adf492a Compare April 22, 2025 01:10
Copy link
Contributor

❌ Gradle check result for adf492a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: kkewwei <kewei.11@bytedance.com>
Copy link
Contributor

✅ Gradle check result for 26c727e: SUCCESS

@msfroh msfroh merged commit eba12fa into opensearch-project:main Apr 23, 2025
31 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Cluster Manager Project Board Apr 23, 2025
@msfroh msfroh added the v3.0.0 Issues and PRs related to version 3.0.0 label Apr 23, 2025
andrross added a commit to andrross/OpenSearch that referenced this pull request Apr 28, 2025
andrross added a commit to andrross/OpenSearch that referenced this pull request Apr 28, 2025
…nsearch-project#17370)"

This reverts commit eba12fa.

Signed-off-by: Andrew Ross <andrross@amazon.com>
andrross added a commit to andrross/OpenSearch that referenced this pull request Apr 28, 2025
…nsearch-project#17370)"

This reverts commit eba12fa.

Signed-off-by: Andrew Ross <andrross@amazon.com>
kotwanikunal pushed a commit that referenced this pull request Apr 29, 2025
)" (#18116)

This reverts commit eba12fa.

Signed-off-by: Andrew Ross <andrross@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cluster Manager enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc v3.0.0 Issues and PRs related to version 3.0.0
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Feature Request] Avoid invalid retries on multiple replicas when querying
4 participants