Make multiple settings dynamic for Merge on Flush #17495
Conversation
kkewwei
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
VachaShah,
bugmakerrrrrr,
jainankitk and
linuxpi
as code owners
github-actions
bot
added
bug
kkewwei
force-pushed
the
dynamic_settings
branch
from
6adb78d to
bbb906f
Compare
|
❌ Gradle check result for bbb906f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❕ Gradle check result for cf7e975: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
|
❌ Gradle check result for c77e86d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
IndexActionIT.testAutoGenerateIdNoDuplicates #16576 |
kkewwei
force-pushed
the
dynamic_settings
branch
from
c77e86d to
cb4b0f1
Compare
|
❌ Gradle check result for cb4b0f1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 11587de: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
@msfroh Could you please continue to review in your spare time? Thank you very much. |
| this.indexWriterConfig = getIndexWriterConfig(); | ||
| writer = createWriter(indexWriterConfig); |
There was a problem hiding this comment.
Just to confirm -- this change will only be "semi-dynamic".
That is, you need to restart the Engine to recreate the IndexWriterConfig and recreate the IndexWriter, right? Is that intentional?
If you call the getIndexWriterConfig() method on InternalEngine, you get a copy of the LiveIndexWriterConfig which affects the current IndexWriter.
I think it might be better to call getIndexWriterConfig() from the onSettingsChanged method to update the LiveIndexWriterConfig. What do you think, @kkewwei?
There was a problem hiding this comment.
By the change, we can dynamic change the settings without restarting the Engine.
…lush_merge_wait_time`, `index.merge_on_flush.policy`, `index.check_pending_flush.enabled` dynamic Signed-off-by: kkewwei <kewei.11@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com>
Signed-off-by: kkewwei <kewei.11@bytedance.com>
|
❌ Gradle check result for ab353dc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Description
index.merge_on_flush.enabledindex.merge_on_flush.max_full_flush_merge_wait_timeindex.merge_on_flush.policyindex.check_pending_flush.enabled.Related Issues
Resolves #10048
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.