Enabled default throttling for all tasks submitted to cluster manager

[gargmanik13]

Description

Enabled default throttling for all tasks submitted to cluster manager.

• Added default threshold values based on task type in ClusterManagerThrottlingDefaults class
• If default threshold value for a task type is not present in ClusterManagerThrottlingDefaults, then we will use 50 as default threshold

Related Issues

Resolves #17685

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.
  • Update Cluster Manager Task Throttling Documentation for 3.0 release documentation-website#9517

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for 031e751:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[gargmanik13]

Test Result (2 failures / -2)
org.opensearch.rest.ReactorNetty4StreamingStressIT.testCloseClientStreamingRequest
org.opensearch.rest.ReactorNetty4StreamingStressIT.classMethod

Flaky Test - #15840

[github-actions]

❌ Gradle check result for 7aa3bc8:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 7aa3bc8: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❕ Gradle check result for f7ca2c0: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Attention: Patch coverage is 97.91667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.57%. Comparing base (54e02a7) to head (56d8ddb).
Report is 18 commits behind head on main.

Files with missing lines	Patch %	Lines
...h/cluster/service/ClusterManagerTaskThrottler.java	77.77%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #17711      +/-   ##
============================================
+ Coverage     72.47%   72.57%   +0.09%     
- Complexity    67034    67137     +103     
============================================
  Files          5478     5473       -5     
  Lines        310132   310132              
  Branches      45087    45058      -29     
============================================
+ Hits         224775   225071     +296     
+ Misses        66960    66693     -267     
+ Partials      18397    18368      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gargmanik13]

❕ Gradle check result for f7ca2c0: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Test Result (1 failure / -34)
org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Flaky Test - #14289

[github-actions]

❌ Gradle check result for d085a1b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[gargmanik13]

❌ Gradle check result for d085a1b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Test Result (2 failures / +2)
org.opensearch.search.simple.SimpleSearchIT.testSimpleTerminateAfterTrackTotalHitsUpToSize {p0={"search.concurrent_segment_search.enabled":"false"}}
org.opensearch.search.simple.SimpleSearchIT.testSimpleTerminateAfterTrackTotalHitsUpToSize {p0={"search.concurrent_segment_search.enabled":"true"}}

Flay test - #16851

[gargmanik13]

Thanks for the change, @gargmanik13

Since we are already changing in every file where we configured throttling, can we make those Throttling keys as enums?

Sure, i've updated Throttling Keys as enum.

[github-actions]

❌ Gradle check result for 399ca2a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 0c601e8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for 56d8ddb: SUCCESS

[opensearch-trigger-bot]

The backport to 3.0 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-3.0 3.0
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-3.0
# Create a new branch
git switch --create backport/backport-17711-to-3.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6ce06282aa3d2bbffe26448fcac23d1b3113112b
# Push it to GitHub
git push --set-upstream origin backport/backport-17711-to-3.0
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-3.0

Then, create a pull request where the base branch is 3.0 and the compare/head branch is backport/backport-17711-to-3.0.