Skip to content

Fix FileInterceptor's delete calls for Unix Domain Sockets on Windows #17873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025

Conversation

reta
Copy link
Contributor

@reta reta commented Apr 10, 2025

Description

Fix FileInterceptor's delete calls for Unix Domain Sockets on Windows

Related Issues

See please https://github.com/opensearch-project/custom-codecs/actions/runs/14370198700/job/40291704566?pr=235

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Andriy Redko <drreta@gmail.com>
Copy link
Contributor

❌ Gradle check result for a10b502: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@cwperks
Copy link
Member

cwperks commented Apr 10, 2025

For one of the failing flaky tests in the latest run, I had opened a PR to fix a reproducible seed: #17389

@kumargu
Copy link
Contributor

kumargu commented Apr 10, 2025

For one of the failed tests in the latest run, I had opened a PR to fix for a reproducible seed: #17389

DedicatedClusterSnapshotRestoreIT.testSnapshotWithStuckNode one has been failing for ages.

But org.opensearch.indexing.IndexActionIT.testAutoGenerateIdNoDuplicates {p0={"cluster.indices.replication.strategy":"SEGMENT"}} seems new.

@cwperks
Copy link
Member

cwperks commented Apr 10, 2025

For one of the failed tests in the latest run, I had opened a PR to fix for a reproducible seed: #17389

DedicatedClusterSnapshotRestoreIT.testSnapshotWithStuckNode one has been failing for ages.

But org.opensearch.indexing.IndexActionIT.testAutoGenerateIdNoDuplicates {p0={"cluster.indices.replication.strategy":"SEGMENT"}} seems new.

I have seen IndexActionIT.testAutoGenerateIdNoDuplicates errors in a few PRs. There's an open PR to address that flaky test as well: #17606

Copy link
Contributor

❌ Gradle check result for a10b502: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for a10b502: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for a10b502: SUCCESS

Copy link

codecov bot commented Apr 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.

Project coverage is 72.45%. Comparing base (7b6108b) to head (a10b502).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
...java/org/opensearch/javaagent/FileInterceptor.java 0.00% 36 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main   #17873   +/-   ##
=========================================
  Coverage     72.44%   72.45%           
- Complexity    66483    66504   +21     
=========================================
  Files          5409     5409           
  Lines        308282   308266   -16     
  Branches      44759    44753    -6     
=========================================
- Hits         223344   223340    -4     
+ Misses        66608    66597   -11     
+ Partials      18330    18329    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@reta
Copy link
Contributor Author

reta commented Apr 10, 2025

@cwperks @andrross mind please re-approving? thank you

@reta reta merged commit 8964f63 into opensearch-project:main Apr 10, 2025
32 of 33 checks passed
rgsriram pushed a commit to rgsriram/OpenSearch that referenced this pull request Apr 15, 2025
…opensearch-project#17873)

* Fix FileInterceptor's delete calls for Unix Domain Sockets on Windows

Signed-off-by: Andriy Redko <drreta@gmail.com>

* Added NetPermission check for UNIX Domain Socket deletion on Windows

Signed-off-by: Andriy Redko <drreta@gmail.com>

---------

Signed-off-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Sriram Ganesh <srignsh22@gmail.com>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
…opensearch-project#17873)

* Fix FileInterceptor's delete calls for Unix Domain Sockets on Windows

Signed-off-by: Andriy Redko <drreta@gmail.com>

* Added NetPermission check for UNIX Domain Socket deletion on Windows

Signed-off-by: Andriy Redko <drreta@gmail.com>

---------

Signed-off-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
…opensearch-project#17873)

* Fix FileInterceptor's delete calls for Unix Domain Sockets on Windows

Signed-off-by: Andriy Redko <drreta@gmail.com>

* Added NetPermission check for UNIX Domain Socket deletion on Windows

Signed-off-by: Andriy Redko <drreta@gmail.com>

---------

Signed-off-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants