-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fix FileInterceptor's delete calls for Unix Domain Sockets on Windows #17873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Andriy Redko <drreta@gmail.com>
libs/agent-sm/agent/src/main/java/org/opensearch/javaagent/FileInterceptor.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andriy Redko <drreta@gmail.com>
❌ Gradle check result for a10b502: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
For one of the failing flaky tests in the latest run, I had opened a PR to fix a reproducible seed: #17389 |
But org.opensearch.indexing.IndexActionIT.testAutoGenerateIdNoDuplicates {p0={"cluster.indices.replication.strategy":"SEGMENT"}} seems new. |
I have seen IndexActionIT.testAutoGenerateIdNoDuplicates errors in a few PRs. There's an open PR to address that flaky test as well: #17606 |
❌ Gradle check result for a10b502: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for a10b502: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17873 +/- ##
=========================================
Coverage 72.44% 72.45%
- Complexity 66483 66504 +21
=========================================
Files 5409 5409
Lines 308282 308266 -16
Branches 44759 44753 -6
=========================================
- Hits 223344 223340 -4
+ Misses 66608 66597 -11
+ Partials 18330 18329 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…opensearch-project#17873) * Fix FileInterceptor's delete calls for Unix Domain Sockets on Windows Signed-off-by: Andriy Redko <drreta@gmail.com> * Added NetPermission check for UNIX Domain Socket deletion on Windows Signed-off-by: Andriy Redko <drreta@gmail.com> --------- Signed-off-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Sriram Ganesh <srignsh22@gmail.com>
…opensearch-project#17873) * Fix FileInterceptor's delete calls for Unix Domain Sockets on Windows Signed-off-by: Andriy Redko <drreta@gmail.com> * Added NetPermission check for UNIX Domain Socket deletion on Windows Signed-off-by: Andriy Redko <drreta@gmail.com> --------- Signed-off-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
…opensearch-project#17873) * Fix FileInterceptor's delete calls for Unix Domain Sockets on Windows Signed-off-by: Andriy Redko <drreta@gmail.com> * Added NetPermission check for UNIX Domain Socket deletion on Windows Signed-off-by: Andriy Redko <drreta@gmail.com> --------- Signed-off-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Description
Fix FileInterceptor's delete calls for Unix Domain Sockets on Windows
Related Issues
See please https://github.com/opensearch-project/custom-codecs/actions/runs/14370198700/job/40291704566?pr=235
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.