Fix testAddReplicaWhileWritesBlocked test under SegmentReplicationWithRemoteStorePressureIT #18067
Conversation
shourya035
requested review from
anasalkouz,
andrross,
ashking94,
bugmakerrrrrr,
Bukhtawar,
CEHENKLE,
cwperks,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
|
@shourya035 without this change, how soon does the test fails? |
| @@ -121,7 +121,7 @@ public static void waitForSearchableDocs(String indexName, long docCount, List<S | |||
| fail("Expected search hits on node: " + node + " to be at least " + docCount + " but was: " + hits); | |||
| } | |||
| } | |||
| }, 1, TimeUnit.MINUTES); | |||
| }, 2, TimeUnit.MINUTES); | |||
There was a problem hiding this comment.
can we consider using assertBusy with fixed interval for wait time?
There was a problem hiding this comment.
This should be better right? With fixed wait time, we would end up slowing down all builds. With this, the build time is increased by 1 minute only in the worst case. Not always.
There was a problem hiding this comment.
can we try using the method assertBusyWithFixedSleepTime with same 1 min interval. I think this issue might be prevalent due to the exponential growth of sleep time.
|
❌ Gradle check result for a1830f3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
With 1 minute wait on |
|
❌ Gradle check result for a1830f3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Description
Fix for
SegmentReplicationWithRemoteStorePressureIT#testAddReplicaWhileWritesBlocked. Test was failing at around 3000 iterations with primary and replica doc count mismatch.Increased assertBusy check to 2 minutes from 1 minutes. After this change, test has been running for over 8000 iterations without failing.
Related Issues
Resolves #[14330]
Check List
[ ] Functionality includes testing.[ ] API changes companion pull request created, if applicable.[ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.