Revert "Avoid invalid retries on multiple replicas when querying"

[andrross]

This reverts commit eba12fa from PR #17370

I was able to get a mostly reliable reproduction with the following command:

./gradlew ':server:internalClusterTest' --tests "org.opensearch.recovery.RecoveryWhileUnderLoadIT" -Dtests.method='testRecoverWhileUnderLoadAllocateReplicasRelocatePrimariesTest' -Dtests.iters=20 -Dtests.seed=C5861E9C93984071 --rerun

Using git bisect I was able to find this commit as the culprit to the recent flakiness in RecoveryWhileUnderLoadIT.

FYI @msfroh @kkewwei

Related Issues

Resolves #14509

Check List

• Functionality includes testing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[msfroh]

Thanks for catching and reverting this!

[github-actions]

❌ Gradle check result for 80c791d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 80c791d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 80c791d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for d168277: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for d168277: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for d168277: SUCCESS

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.55%. Comparing base (1d998f1) to head (d168277).
Report is 7 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #18116      +/-   ##
============================================
+ Coverage     72.52%   72.55%   +0.02%     
+ Complexity    67261    67231      -30     
============================================
  Files          5476     5476              
  Lines        310369   310360       -9     
  Branches      45123    45120       -3     
============================================
+ Hits         225100   225170      +70     
+ Misses        66924    66837      -87     
- Partials      18345    18353       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.