Skip to content

Mute WarmIndexSegmentReplicationIT #18176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

andrross
Copy link
Member

@andrross andrross commented May 1, 2025

This is a new test that is pretty flaky. Muting it now while the feature is still under development.

@gbbafna @skumawat2025 Please take a look. If there's a quick fix we can discard this PR, but otherwise I'd prefer to merge this in the meantime to stabilize the tests.

Related to #18157

Check List

  • Functionality includes testing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This is a new test that is pretty flaky. Muting it now while the feature
is still under development.

Signed-off-by: Andrew Ross <andrross@amazon.com>
@andrross andrross requested a review from a team as a code owner May 1, 2025 20:34
@skumawat2025
Copy link
Contributor

skumawat2025 commented May 1, 2025

This PR got merged almost two months back: #17390. We started seeing these failure recently. I will check this @andrross. Looking at this report #18157 I see only testPrimaryStopped_ReplicaPromoted test is flaky. Can we mute this specific test for now if possible?

Copy link
Contributor

github-actions bot commented May 1, 2025

✅ Gradle check result for 8952e66: SUCCESS

Copy link

codecov bot commented May 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.45%. Comparing base (2ba6aac) to head (8952e66).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18176      +/-   ##
============================================
- Coverage     72.52%   72.45%   -0.07%     
- Complexity    67177    67199      +22     
============================================
  Files          5476     5476              
  Lines        310444   310444              
  Branches      45120    45120              
============================================
- Hits         225144   224929     -215     
- Misses        66870    67199     +329     
+ Partials      18430    18316     -114     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrross
Copy link
Member Author

andrross commented May 1, 2025

This PR got merged almost two months back: #17390. We started seeing these failure recently. I will check this @andrross. Looking at this report #18157 I see only testPrimaryStopped_ReplicaPromoted test is flaky. Can we mute this specific test for now if possible?

@skumawat2025 Take a look at the impacted PRs in #18157. There are older failures, such as this one for testIndexReopenClose from March 19. I've also seen failures for testDeleteOperations and testPrimaryReceivesDocsDuringReplicaRecovery.

@andrross
Copy link
Member Author

andrross commented May 1, 2025

@skumawat2025 You can also look at the stats from the Gradle Check Dashboard. It looks like the first failure was on March 11 and 10 different tests have failed.

@skumawat2025
Copy link
Contributor

skumawat2025 commented May 1, 2025

Okay, I see the issue was created 2 days ago, which is why the failure went unnoticed.. @andrross We can mute these for now. Will work on fixing these soon.

@andrross
Copy link
Member Author

andrross commented May 1, 2025

Thanks @skumawat2025!

Okay, I see the issue was created 2 days ago

The automation doesn't open issues until the test has failed a couple times on the post-commit triggered runs to filter out failures that were caused by unmerged code in PRs.

which is why the failure went unnoticed

Yeah, the primary reason I'm on a crusade now to stabilize the tests is so that new flakiness doesn't get lost in all the noise that we currently have.

@mch2 mch2 merged commit c0f4705 into opensearch-project:main May 1, 2025
35 of 36 checks passed
@andrross andrross deleted the mute-WarmIndexSegmentReplicationIT branch May 2, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants