Skip to content

Fixing Flaky ReactorNetty4StreamingStressIT test case (another attempt) #18193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

reta
Copy link
Contributor

@reta reta commented May 4, 2025

Description

Fixing Flaky ReactorNetty4StreamingStressIT test case (another attempt)

Related Issues

Closes #15840

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta reta added flaky-test Random test failure that succeeds on second run skip-changelog labels May 4, 2025
@reta reta requested a review from a team as a code owner May 4, 2025 14:56
@github-actions github-actions bot added >test-failure Test failure from CI, local build, etc. autocut disabled-test Issues that are used by an AwaitsFix annotation to temporarily disable a broken test labels May 4, 2025
Copy link
Contributor

github-actions bot commented May 4, 2025

❌ Gradle check result for 3492c1a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta reta force-pushed the issue-15840.1 branch 2 times, most recently from 839d233 to 68e0a29 Compare May 4, 2025 16:43
Copy link
Contributor

github-actions bot commented May 4, 2025

❕ Gradle check result for 68e0a29: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented May 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.61%. Comparing base (4c2d043) to head (56085e1).
Report is 12 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18193      +/-   ##
============================================
+ Coverage     72.54%   72.61%   +0.06%     
- Complexity    67234    67278      +44     
============================================
  Files          5476     5476              
  Lines        310444   310452       +8     
  Branches      45120    45123       +3     
============================================
+ Hits         225211   225422     +211     
+ Misses        66834    66699     -135     
+ Partials      18399    18331      -68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@reta reta marked this pull request as draft May 4, 2025 19:16
@reta reta force-pushed the issue-15840.1 branch 4 times, most recently from bae251b to 971373e Compare May 4, 2025 22:37
Copy link
Contributor

github-actions bot commented May 4, 2025

✅ Gradle check result for 971373e: SUCCESS

@reta reta force-pushed the issue-15840.1 branch from 971373e to 076033c Compare May 5, 2025 00:45
Copy link
Contributor

github-actions bot commented May 5, 2025

❌ Gradle check result for 076033c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented May 5, 2025

✅ Gradle check result for 076033c: SUCCESS

@reta reta force-pushed the issue-15840.1 branch from 076033c to 91c1f7e Compare May 6, 2025 00:02
Signed-off-by: Andriy Redko <drreta@gmail.com>
@reta reta force-pushed the issue-15840.1 branch from 91c1f7e to 56085e1 Compare May 6, 2025 00:53
@reta reta marked this pull request as ready for review May 6, 2025 01:01
Copy link
Contributor

github-actions bot commented May 6, 2025

✅ Gradle check result for 56085e1: SUCCESS

@andrross andrross merged commit b06ccd2 into opensearch-project:main May 6, 2025
32 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 3.0 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-3.0 3.0
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-3.0
# Create a new branch
git switch --create backport/backport-18193-to-3.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b06ccd23e4e4bdde355423d05bcb4b454249cc9a
# Push it to GitHub
git push --set-upstream origin backport/backport-18193-to-3.0
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-3.0

Then, create a pull request where the base branch is 3.0 and the compare/head branch is backport/backport-18193-to-3.0.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.19 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.19 2.19
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.19
# Create a new branch
git switch --create backport/backport-18193-to-2.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b06ccd23e4e4bdde355423d05bcb4b454249cc9a
# Push it to GitHub
git push --set-upstream origin backport/backport-18193-to-2.19
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.19

Then, create a pull request where the base branch is 2.19 and the compare/head branch is backport/backport-18193-to-2.19.

reta added a commit to reta/OpenSearch that referenced this pull request May 6, 2025
…t) (opensearch-project#18193)

Signed-off-by: Andriy Redko <drreta@gmail.com>
(cherry picked from commit b06ccd2)
reta added a commit to reta/OpenSearch that referenced this pull request May 6, 2025
…t) (opensearch-project#18193)

Signed-off-by: Andriy Redko <drreta@gmail.com>
(cherry picked from commit b06ccd2)
andrross pushed a commit that referenced this pull request May 6, 2025
…t) (#18193) (#18222)

(cherry picked from commit b06ccd2)

Signed-off-by: Andriy Redko <drreta@gmail.com>
andrross pushed a commit that referenced this pull request May 7, 2025
…t) (#18193) (#18221)

(cherry picked from commit b06ccd2)

Signed-off-by: Andriy Redko <drreta@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut backport 2.19 backport 3.0 backport-failed disabled-test Issues that are used by an AwaitsFix annotation to temporarily disable a broken test flaky-test Random test failure that succeeds on second run skip-changelog >test-failure Test failure from CI, local build, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AUTOCUT] Gradle Check Flaky Test Report for ReactorNetty4StreamingStressIT
2 participants