Skip to content

Add a dynamic setting to change skip_cache_factor and min_frequency for querycache #18351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add a dynamic setting to change skip_cache_factor and min_frequency for querycache #18351

wants to merge 6 commits into from

Conversation

kkewwei
Copy link
Collaborator

@kkewwei kkewwei commented May 21, 2025 •
edited
Loading

Description

[Describe what this change achieves]

Related Issues

Resolves #17736

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Search:Performance v3.0.0 Issues and PRs related to version 3.0.0 labels May 21, 2025
@kkewwei kkewwei force-pushed the add_skip_factor branch from c31602e to bb809f7 Compare May 21, 2025 16:56
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for bb809f7: SUCCESS

@codecov Codecov
Copy link

codecov bot commented May 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.74468% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.73%. Comparing base (fe4a98d) to head (12f4192).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...java/org/opensearch/indices/IndicesQueryCache.java 95.34% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #18351      +/-   ##
============================================
+ Coverage     72.60%   72.73%   +0.12%     
- Complexity    67682    67759      +77     
============================================
  Files          5497     5497              
  Lines        311819   311859      +40     
  Branches      45265    45274       +9     
============================================
+ Hits         226409   226821     +412     
+ Misses        66941    66564     -377     
- Partials      18469    18474       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sgup432
sgup432 reviewed May 21, 2025
View reviewed changes
@kkewwei kkewwei force-pushed the add_skip_factor branch 2 times, most recently from ed6544e to 4dac9a6 Compare May 23, 2025 15:56
@kkewwei kkewwei reopened this May 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 36c9282: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei closed this May 26, 2025
@kkewwei kkewwei reopened this May 26, 2025
@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 36c9282: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@kkewwei
Copy link
Collaborator Author

kkewwei commented May 26, 2025

❌ Gradle check result for 36c9282: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

SearchIT.testSearchWithMatrixStats #18129

@kkewwei kkewwei mentioned this pull request May 26, 2025
Merged
3 tasks
@kkewwei kkewwei closed this May 26, 2025
@kkewwei kkewwei reopened this May 26, 2025
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 58e444a: SUCCESS

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 43ec899: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@kkewwei
Copy link
Collaborator Author

kkewwei commented May 28, 2025

@sgup432 please help review in your spare time.

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request May 21, 2025
Open
@kkewwei kkewwei closed this May 28, 2025
@kkewwei kkewwei reopened this May 28, 2025
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 43ec899: SUCCESS

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 4048818: SUCCESS

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request May 28, 2025
Closed
sgup432
sgup432 reviewed May 29, 2025
View reviewed changes
@kkewwei kkewwei force-pushed the add_skip_factor branch from 4048818 to cb591e0 Compare May 30, 2025 01:14
@kkewwei
add volatile to variable
12f4192 
Signed-off-by: kkewwei <kkewwei@163.com>
Signed-off-by: kkewwei <kewei.11@bytedance.com>
@kkewwei kkewwei force-pushed the add_skip_factor branch from cb591e0 to 12f4192 Compare May 30, 2025 01:17
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 12f4192: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

sgup432
sgup432 approved these changes May 30, 2025
View reviewed changes
Copy link
Contributor

@sgup432 sgup432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kkewwei
Copy link
Collaborator Author

kkewwei commented May 30, 2025

@sandeshkr419 Can you also help review in your spare time. If there is no problem, I will merge the pr.

@kkewwei kkewwei closed this May 30, 2025
@kkewwei kkewwei reopened this May 30, 2025
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 12f4192: SUCCESS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgup432 sgup432 sgup432 approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement Enhancement or improvement to existing feature or request Search:Performance v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Query Cache] Add a dynamic cluster setting to change skip cache factor
2 participants
@kkewwei @sgup432