Skip to content

[Backport 2.7] Fix store type settings ordering for searchable snapshots #7299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 72ed13b from #7297.

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
(cherry picked from commit 72ed13b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=pit/10_basic/Delete all}

@codecov-commenter
Copy link

Codecov Report

Merging #7299 (9ec4420) into 2.7 (bb32f75) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.7    #7299      +/-   ##
============================================
- Coverage     70.46%   70.44%   -0.03%     
+ Complexity    59774    59742      -32     
============================================
  Files          4847     4847              
  Lines        287163   287177      +14     
  Branches      41723    41725       +2     
============================================
- Hits         202346   202298      -48     
- Misses        67860    67933      +73     
+ Partials      16957    16946      -11     
Impacted Files Coverage Δ
...earch/index/SegmentReplicationPressureService.java 77.31% <ø> (ø)
.../java/org/opensearch/snapshots/RestoreService.java 54.21% <0.00%> (ø)

... and 506 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Rishikesh1159
Copy link
Member

Will hold on merging this PR to 2.7 until we get confirmation from @andrross or @kotwanikunal

@kotwanikunal
Copy link
Member

I had a chat with @zelinh offline for pushing this change to 2.7. Merging this in post approval.

@kotwanikunal kotwanikunal merged commit b7a6e09 into 2.7 Apr 25, 2023
@github-actions github-actions bot deleted the backport/backport-7297-to-2.7 branch April 25, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants