Skip to content

[Segment Replication] Remove Doc Parsing for segment replication enabled replica shard during translog replay from recovery #9002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 6, 2023
Merged

[Segment Replication] Remove Doc Parsing for segment replication enabled replica shard during translog replay from recovery #9002

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
51a027b
Remove Doc Parsing for segment replication enabled replica shard duri…
Rishikesh1159 Jul 31, 2023
db990b9
Adding unit test to verify document is not parsed on an segment repli…
Rishikesh1159 Aug 2, 2023
62e9d8c
remove unnecessary unit tests and address comments.
Rishikesh1159 Aug 2, 2023
060c106
Merge branch 'opensearch-project:main' into fix-seqNo-Prcesses-twice-bug
Rishikesh1159 Aug 2, 2023
79cf317
address comments on PR.
Rishikesh1159 Aug 6, 2023
b0ebb6f
Merge branch 'fix-seqNo-Prcesses-twice-bug' of https://github.com/Ris…
Rishikesh1159 Aug 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 26 additions & 21 deletions server/src/main/java/org/opensearch/index/shard/IndexShard.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,7 +931,8 @@ public Engine.IndexResult applyIndexOperationOnPrimary(
autoGeneratedTimestamp,
isRetry,
Engine.Operation.Origin.PRIMARY,
sourceToParse
sourceToParse,
null
);
}

Expand All @@ -944,23 +945,6 @@ public Engine.IndexResult applyIndexOperationOnReplica(
boolean isRetry,
SourceToParse sourceToParse
) throws IOException {
if (indexSettings.isSegRepEnabled()) {
Engine.Index index = new Engine.Index(
new Term(IdFieldMapper.NAME, Uid.encodeId(id)),
new ParsedDocument(null, null, id, null, null, sourceToParse.source(), sourceToParse.getMediaType(), null),
seqNo,
opPrimaryTerm,
version,
null,
Engine.Operation.Origin.REPLICA,
System.nanoTime(),
autoGeneratedTimeStamp,
isRetry,
UNASSIGNED_SEQ_NO,
0
);
return getEngine().index(index);
}
return applyIndexOperation(
getEngine(),
seqNo,
Expand All @@ -972,7 +956,8 @@ public Engine.IndexResult applyIndexOperationOnReplica(
autoGeneratedTimeStamp,
isRetry,
Engine.Operation.Origin.REPLICA,
sourceToParse
sourceToParse,
id
);
}

Expand All @@ -987,8 +972,27 @@ private Engine.IndexResult applyIndexOperation(
long autoGeneratedTimeStamp,
boolean isRetry,
Engine.Operation.Origin origin,
SourceToParse sourceToParse
SourceToParse sourceToParse,
String id
) throws IOException {
if (indexSettings.isSegRepEnabled() && routingEntry().primary() == false && getReplicationEngine().isPresent()) {
Engine.Index index = new Engine.Index(
new Term(IdFieldMapper.NAME, Uid.encodeId(id)),
new ParsedDocument(null, null, id, null, null, sourceToParse.source(), sourceToParse.getMediaType(), null),
seqNo,
opPrimaryTerm,
version,
null,
Engine.Operation.Origin.REPLICA,
System.nanoTime(),
autoGeneratedTimeStamp,
isRetry,
UNASSIGNED_SEQ_NO,
0
);
return getEngine().index(index);
}

assert opPrimaryTerm <= getOperationPrimaryTerm() : "op term [ "
+ opPrimaryTerm
+ " ] > shard term ["
Expand Down Expand Up @@ -2173,7 +2177,8 @@ private Engine.Result applyTranslogOperation(Engine engine, Translog.Operation o
index.source(),
MediaTypeRegistry.xContentType(index.source()),
index.routing()
)
),
index.id()
);
break;
case DELETE:
Expand Down