Downgrade qat-java version to 1.2.0.

[mulugetam]

Description

Downgrades QAT-Java to version 1.2.0 due to customer readiness constraints, as version 2.2.1 depends on a QATzip release that has not yet been adopted in their environments.

[mgodwan]

Could you update the licenses as well?

[mulugetam]

updated.

[mgodwan]

Was the unavailability of dependency not caught in tests?

[mulugetam]

@mgodwan All versions of QAT-Java require the underlying system to have QAT hardware and that it is properly configured. If not, it will either fall back to software execution (for auto mode) or throw an exception (or hardware only). The downgrade was requested solely because customers are not yet ready to upgrade their drivers and/or the QATzip library to make use of the latest features and improvements.

[mgodwan]

Would this downgrade take away the support for LZ4/Defalte as well?
I'm coming from release notes captured here: https://github.com/intel/qat-java/releases

[mulugetam]

No, it does not. I understand this might be somewhat confusing, but the mention of DEFLATE and LZ4 in the 2.2.1 release notes was intended to clarify that it supports only DEFLATE and LZ4—unlike other 2.x versions, which support DEFLATE, LZ4, and ZSTD.

[hector-cao]

@mgodwan Hello, thanks for the review. Do you think that we are good to go for this to be approved ? We are blocked by this to be able to enable QAT foe Canonical opensearch product

[andrross]

The downgrade was requested solely because customers are not yet ready to upgrade their drivers and/or the QATzip library to make use of the latest features and improvements.

@mulugetam But what about the customers that want the upgraded version with the latest features and improvements? I'm fine with merging this PR for now because we haven't yet released a version with the newer qat-java, but it seems like we might need a more flexible strategy as it is unlikely we'll be able to make everyone happy.

[opensearch-trigger-bot]

The backport to 3.1 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/custom-codecs/backport-3.1 3.1
# Navigate to the new working tree
pushd ../.worktrees/custom-codecs/backport-3.1
# Create a new branch
git switch --create backport/backport-254-to-3.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6245b46f6a6a7964b0764a54781fd52fe709cfbf
# Push it to GitHub
git push --set-upstream origin backport/backport-254-to-3.1
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/custom-codecs/backport-3.1

Then, create a pull request where the base branch is 3.1 and the compare/head branch is backport/backport-254-to-3.1.

[andrross]

@mulugetam I'm just now noticing this merged to the 2.19 branch. Do you want to keep the newer version for the 3.1 and later releases?

[mulugetam]

@andrross Yes, I want to keep the latest qat-java version, 2.3.2, for 3.1 and later releases. Thanks!