Skip to content

Downgrade qat-java version to 1.2.0. #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2025
+2 −2
Merged

Downgrade qat-java version to 1.2.0. #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0023eaf
Update qat-java version to 1.2.0.
mulugetam Jun 17, 2025
c0bc0e9
Update qat-java licenses.
mulugetam Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ opensearchplugin {

dependencies {
api "com.github.luben:zstd-jni:1.5.5-5"
api "com.intel.qat:qat-java:2.2.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the unavailability of dependency not caught in tests?

Copy link
Contributor Author

@mulugetam mulugetam Jun 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgodwan All versions of QAT-Java require the underlying system to have QAT hardware and that it is properly configured. If not, it will either fall back to software execution (for auto mode) or throw an exception (or hardware only). The downgrade was requested solely because customers are not yet ready to upgrade their drivers and/or the QATzip library to make use of the latest features and improvements.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this downgrade take away the support for LZ4/Defalte as well?
I'm coming from release notes captured here: https://github.com/intel/qat-java/releases

Copy link
Contributor Author

@mulugetam mulugetam Jun 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it does not. I understand this might be somewhat confusing, but the mention of DEFLATE and LZ4 in the 2.2.1 release notes was intended to clarify that it supports only DEFLATE and LZ4—unlike other 2.x versions, which support DEFLATE, LZ4, and ZSTD.

api "com.intel.qat:qat-java:1.2.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the licenses as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

}

allprojects {
Expand Down
1 change: 1 addition & 0 deletions licenses/qat-java-1.2.0.jar.sha1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
a99c4c854daf9ae0ff2b90e9ae9bef00f231c2f6
1 change: 0 additions & 1 deletion licenses/qat-java-2.2.1.jar.sha1
View file
Open in desktop

This file was deleted.

Loading