-
Notifications
You must be signed in to change notification settings - Fork 577
adding percentile and percentile rank docs #10201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
adding percentile and percentile rank docs #10201
Conversation
Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>
@jainankitk Could you review this PR please? Thanks! |
Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>
Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>
Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>
Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>
Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>
Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>
"hits": { | ||
"total": { | ||
"value": 7, | ||
"relation": "eq" | ||
}, | ||
"max_score": null, | ||
"hits": [] | ||
}, | ||
"aggregations": { | ||
"rank_check": { | ||
"values": [ | ||
{ | ||
"key": 25, | ||
"value": 28.57142857142857 | ||
}, | ||
{ | ||
"key": 55, | ||
"value": 71.42857142857143 | ||
} | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The response here should not be keyed, right?
```json | ||
{ | ||
... | ||
"aggregations": { | ||
"load_time_percentiles": { | ||
"values": [ | ||
{ | ||
"key": 1, | ||
"value": 20 | ||
}, | ||
{ | ||
"key": 5, | ||
"value": 20 | ||
}, | ||
{ | ||
"key": 25, | ||
"value": 40 | ||
}, | ||
{ | ||
"key": 50, | ||
"value": 80 | ||
}, | ||
{ | ||
"key": 75, | ||
"value": 120 | ||
}, | ||
{ | ||
"key": 95, | ||
"value": 140 | ||
}, | ||
{ | ||
"key": 99, | ||
"value": 140 | ||
} | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here also the response should be non-keyed?
Description
adding percentile rank docs
Version
all
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.