adding rank_feature dsl query docs #9927
Merged
+547
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>
AntonEliatra
requested review from
kolchfa-aws,
Naarcha-AWS,
AMoo-Miki,
natebower,
dlvenable and
epugh
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
kolchfa-aws
added
Tech review
|
@kaushalmahi12 Could you review this PR? Thanks! |
Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>
|
@kaushalmahi12 thank you for the review, I have now addressed the comments, please have a look again |
kaushalmahi12
approved these changes
Jul 8, 2025
kolchfa-aws
reviewed
Jul 9, 2025
There was a problem hiding this comment.
Thank you, @AntonEliatra! Please see my comments and let me know if you have any questions.
| | ----------------------- | ----------------- | ------------------------------------------------------------------------------------------------------------------------ | | ||
| | `field` | Required | A `rank_feature` or `rank_features` field that contributes to document scoring.| | ||
| | `boost` | Optional | A multiplier applied to the score. Default is `1.0`. Values between 0 and 1 reduce the score, values above 1 amplify it. | | ||
| | `saturation` | Optional | Applies a saturation function to the feature value. Boost grows with value but levels off beyond the `pivot`. (Default function if no other function is provided)| |
There was a problem hiding this comment.
Link to the function sections See [Saturation](#saturation).
|
|
||
| ## Parameters | ||
|
|
||
| | Parameter | Required/Optional | Description | |
There was a problem hiding this comment.
Could you add a "Data type" column here? Some of these are non-obvious.
kolchfa-aws
added
Doc review
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>
Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>
kolchfa-aws
added
Editorial review
Signed-off-by: Nathan Bower <nbower@amazon.com>
natebower
approved these changes
Jul 10, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 10, 2025
* adding rank_feature dsl query docs Signed-off-by: Anton Rubin <anton.rubin@eliatra.com> * addressing PR comments Signed-off-by: Anton Rubin <anton.rubin@eliatra.com> * Apply suggestions from code review Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> * addressing the PR comments Signed-off-by: Anton Rubin <anton.rubin@eliatra.com> * Apply suggestions from code review Signed-off-by: Nathan Bower <nbower@amazon.com> --------- Signed-off-by: Anton Rubin <anton.rubin@eliatra.com> Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> Signed-off-by: Nathan Bower <nbower@amazon.com> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com> (cherry picked from commit d1a3143) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
added a commit
that referenced
this pull request
Jul 10, 2025
* adding rank_feature dsl query docs * addressing PR comments * Apply suggestions from code review * addressing the PR comments * Apply suggestions from code review --------- (cherry picked from commit d1a3143) Signed-off-by: Anton Rubin <anton.rubin@eliatra.com> Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> Signed-off-by: Nathan Bower <nbower@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adding rank_feature dsl query docs
Version
all
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.