Fix operation "convert_index_to_remote" bug . Rmote index name using the remote_ prefix instead of _remote suffix w… #1427
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuyonghengheng
requested review from
bowenlan-amzn,
Hailong-am,
vikasvb90,
tandonks,
shiv0408 and
soosinha
as code owners
…hen the convert_index_to_remote operation restored the target index . Signed-off-by: liuyongheng <liuyongheng@liuyongheng.localdomain>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hen the convert_index_to_remote operation restored the target index .
Description
The "convert_index_to_remote" operation restored the target index suffixed whith "remote". In most cases, this new index will match the same policy as the original index, which can trigger the index management process again (although it will fail due to read-only ). This is not what we want. To avoid this issue, we can use the "remote" prefix instead of "_remote" suffix .
Related Issues
Resolves #1426
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.