Skip to content

[WIP] Improving E2E Tests #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 56 commits into
base: main
Choose a base branch
from
Draft

[WIP] Improving E2E Tests #1138

wants to merge 56 commits into from

Conversation

aalva500-prog
Copy link
Contributor

@aalva500-prog aalva500-prog commented May 2, 2025 •
edited
Loading

Description

I have added this PR with a solution that adds a retry mechanism with exponential backoff for the S3 connection. This solution will:

  • Try to connect to the S3 service multiple times with increasing delays
  • Only proceed with table creation once the S3 service is confirmed to be available
  • Fail the test with a clear error message if the S3 service doesn't become available after multiple attempts
  • This should make our tests more robust against timing issues with container startup.

Related Issues

#1092 [Flacky E2E] com.amazonaws.SdkClientException: Unable to execute HTTP request

Check List

  • Updated documentation (docs/ppl-lang/README.md)
  • Implemented unit tests
  • Implemented tests for combination with other commands
  • New added source code should include a copyright header
  • Commits are signed per the DCO using --signoff
  • Add backport 0.x label if it is a stable change which won't break existing feature

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@aalva500-prog aalva500-prog changed the title Improving E2E Test [WIP ]Improving E2E Tests May 2, 2025
@aalva500-prog aalva500-prog changed the title [WIP ]Improving E2E Tests [WIP] Improving E2E Tests May 2, 2025
@aalva500-prog aalva500-prog changed the base branch from main to 0.x May 3, 2025 04:16
@aalva500-prog aalva500-prog changed the base branch from 0.x to main May 3, 2025 04:17
@aalva500-prog aalva500-prog changed the base branch from main to 0.x May 3, 2025 04:18
@aalva500-prog aalva500-prog changed the base branch from 0.x to main May 3, 2025 04:21
toepkerd and others added 21 commits May 6, 2025 17:42
@toepkerd @toepkerd-zz @aaarone90
Adding fast refresh setting during index creation (opensearch-project…
ed1e582 
…#1074)

* Adding fast refresh setting during index creation

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* abstracting refresh setting outside of OSclient implementation

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* adjusting settings to match that of opensearch index settings

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* addressing comment

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* adding malformed settings unit test

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* fix formatting issues

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* misc dev changes (unpolished, for testing purposes)

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* adding fast refresh check

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* formatting

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* adding inspect exception

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* formatting

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* adjusting setting name

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* cleanup

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* even more cleanup

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* even more cleanup

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* runback 1

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* runback 2

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* adding malformed settings docker image test

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* polishing malformed settings and mappings docker image tests

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* cleanup

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

---------

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>
Co-authored-by: Dennis Toepker <toepkerd@amazon.com>
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Improving E2E Test
cb289f0 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Trigger CI
a1b833c 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Trigger CI
b07c7b8 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Trigger CI
fd0c71c 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Ignore all tests to rule out flacky connectivity
7f6cc9e 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Testing only SQL Queries
263c66b 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Testing SQL queries only
23cfb58 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Testing Spark SQL Queries only
0e88f71 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Testing Spark SQL Queries Only
031d53a 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Empty commit for CI/CD trigger
038d276 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Empty commit for CI/CD trigger
653ed8b 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Empty commit for CI/CD trigger
a0eb2f9 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Increased OpenSearch Container memory
88f592b 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Run again ignoring all tests
8d326f1 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Fixing scala formatting issues
dd732f1 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Testing Spark SQL Queries only
b44bfda 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Testing Spark SQL Queries Only
ef4a54a 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Testing Spark SQL Queries Only
e938eff 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Empty commit for CI/CD trigger
f1ec991 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Testing Spark SQL Queries only
4abecd3 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
aaarone90 added 9 commits May 6, 2025 17:42
@aaarone90
Capturing more log details
45aab92 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Testing Spark SQL Queries Only
d2a975b 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Improving Docker containers creation
13e2f21 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Using original file, as late code changes are not working
ce28ff7 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
This changes worked locally, so I'm testing now in the Github repo
9d51ac4 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Fixing Docker Compose
0dc1998 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Fixing S3 access issue
17f2410 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Rerun CI
f977a95 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Stop tracking file
83d80c8 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
aalva500-prog and others added 20 commits May 6, 2025 13:49
@aalva500-prog
Merge branch 'opensearch-project:main' into e2eTests
6ab1ff9
@aaarone90
Add configuration updater script
3cc99ec 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Adding additional details to help pass the Github Action Tests
dc2ed61 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Fixing Scala Formatting
6cd61bb 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Fixing end-to-end flow in Github actions
4e71e73 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Fixing end-to-end workflow
286a602 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Fixing Docker compose command
369e683 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Adding more detailed health checks, as Docker containers are failing …
de14919 
…to be created

Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Change the GitHub workflow to address the OpenSearch container health…
43ff684 
… issue

Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Trying to fix connectivity issues
48beecd 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Enhancing error handling
f5431e6 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Making more changes to avoid connectivity issues with Docker
710f196 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Fixing Scala Formatting
ecc78d8 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Fixing Scala Formatting Issues
bfb6568 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Simplifying the end-to-end-test-workflow.yml file
3f14688 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Adding more logic to check why is not connecting to Spark
5afd91f 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Fixing Spark Connect issues
2a9a5b5 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Simplifying the end-to-end test workflow
dc415d5 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Adding changes to avoid S3 issue connectivity
ef8cc2f 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Trying to make the connection to S3 work
be8ecd3 
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen will be requested when the pull request is marked ready for review dai-chen is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric will be requested when the pull request is marked ready for review mengweieric is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo will be requested when the pull request is marked ready for review penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az will be requested when the pull request is marked ready for review seankao-az is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha will be requested when the pull request is marked ready for review anirudha is a code owner

@kaituo kaituo Awaiting requested review from kaituo kaituo will be requested when the pull request is marked ready for review kaituo is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB will be requested when the pull request is marked ready for review YANG-DB is a code owner

@noCharger noCharger Awaiting requested review from noCharger noCharger will be requested when the pull request is marked ready for review noCharger is a code owner

@LantaoJin LantaoJin Awaiting requested review from LantaoJin LantaoJin will be requested when the pull request is marked ready for review LantaoJin is a code owner

@ykmr1224 ykmr1224 Awaiting requested review from ykmr1224 ykmr1224 will be requested when the pull request is marked ready for review ykmr1224 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aalva500-prog @toepkerd @aaarone90