removing usage of doc id in skipping index while document creation #1253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mayank Aggarwal <aggmayan@amazon.com>
aggarwalmayank
requested review from
LantaoJin,
YANG-DB,
anirudha,
dai-chen,
kaituo,
mengweieric,
noCharger,
penghuo,
seankao-az and
ykmr1224
as code owners
dai-chen
reviewed
Aug 13, 2025
Collaborator
dai-chen
left a comment
dai-chen
left a comment
There was a problem hiding this comment.
Please add new IT for skipping index without doc ID and simulate the case that with duplicate document in it, the behavior is still correct.
| df.getOrElse(spark.read.table(quotedTableName(tableName))) | ||
| .groupBy(input_file_name().as(FILE_PATH_COLUMN)) | ||
| .agg(namedAggFuncs.head, namedAggFuncs.tail: _*) | ||
| .withColumn(ID_COLUMN, sha1(col(FILE_PATH_COLUMN))) |
Collaborator
There was a problem hiding this comment.
Is this PoC PR or not? I think in production we should make it configurable instead of removing it always?
|
This PR is stalled because it has been open for 30 days with no activity. |
Contributor
|
Hi @aggarwalmayank Do we still need this change ? |
|
This PR is stalled because it has been open for 30 days with no activity. |
Contributor
|
Closing this one for now, and feel free to re-open if needed @aggarwalmayank |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe what this change achieves.
In OpenSearch Serverless (AOSS) time series collections, document creation and update operations fail when a document ID is specified, this change removed the usage of doc ID while writing as it is not required for skipping index to work.
Related Issues
List any issues this PR will resolve, e.g. Resolves [...].
#1012
Check List
--signoffbackport 0.xlabel if it is a stable change which won't break existing featureBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.