-
Notifications
You must be signed in to change notification settings - Fork 50
Adding connection timeout override for 10 seconds #1273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dai-chen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check and fix the CI failure.
flint-spark-integration/src/main/scala/org/apache/spark/sql/flint/config/FlintSparkConf.scala
Show resolved
Hide resolved
I checked the CI failure here and I was seeing this error However there were no other logs that were helping me debug this further. I checked out main and tried to build locally and was still getting the same error. Am I missing something here? |
Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>
…ch-spark Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>
dai-chen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
flint-core/src/main/scala/org/opensearch/flint/core/storage/RequestConfigurator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>
* Adding connection timeout override for 10 seconds Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com> * chaining request config builder options Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com> --------- Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com> (cherry picked from commit 9b5c6ed) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Adding connection timeout override for 10 seconds Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com> * chaining request config builder options Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com> --------- Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com> (cherry picked from commit 9b5c6ed) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Adding connection timeout override for 10 seconds Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com> * chaining request config builder options Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com> --------- Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com> (cherry picked from commit 9b5c6ed) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Adding connection timeout override for 10 seconds * chaining request config builder options --------- (cherry picked from commit 9b5c6ed) Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Adding connection timeout override for 10 seconds Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com> * chaining request config builder options Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com> --------- Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com> (cherry picked from commit 9b5c6ed) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Adding connection timeout override for 10 seconds * chaining request config builder options --------- (cherry picked from commit 9b5c6ed) Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Overriding the default connection timeout for connection to opensearch from 1 second which was overly aggressive to 10 seconds
Related Issues
This commit resolves the frequent aoss connection timeouts issues faced which occur intermittently for api calls to aoss
Check List
NA
NA (just an override change, no new functionality)
NA (same as above)
NA
--signoffbackport 0.xlabel if it is a stable change which won't break existing featureBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.