Skip to content

Conversation

@sachin-27
Copy link
Contributor

Description

Overriding the default connection timeout for connection to opensearch from 1 second which was overly aggressive to 10 seconds

Related Issues

This commit resolves the frequent aoss connection timeouts issues faced which occur intermittently for api calls to aoss

Check List

  • Updated documentation (docs/ppl-lang/README.md)
    NA
  • Implemented unit tests
    NA (just an override change, no new functionality)
  • Implemented tests for combination with other commands
    NA (same as above)
  • New added source code should include a copyright header
    NA
  • [x ] Commits are signed per the DCO using --signoff
  • Add backport 0.x label if it is a stable change which won't break existing feature

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check and fix the CI failure.

@sachin-27 sachin-27 closed this Oct 15, 2025
@sachin-27 sachin-27 reopened this Oct 15, 2025
@sachin-27
Copy link
Contributor Author

sachin-27 commented Oct 16, 2025

Please check and fix the CI failure.

I checked the CI failure here and I was seeing this error

[error] (pplSparkIntegration / Compile / compileIncremental) javac returned non-zero exit code

However there were no other logs that were helping me debug this further. I checked out main and tried to build locally and was still getting the same error. Am I missing something here?

Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>
@dai-chen dai-chen merged commit 9b5c6ed into opensearch-project:main Oct 30, 2025
4 of 6 checks passed
@dai-chen dai-chen added backport 0.x Backport to 0.x branch (stable branch) backport 0.7 labels Nov 4, 2025
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 4, 2025
* Adding connection timeout override for 10 seconds

Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>

* chaining request config builder options

Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>

---------

Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>
(cherry picked from commit 9b5c6ed)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 4, 2025
* Adding connection timeout override for 10 seconds

Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>

* chaining request config builder options

Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>

---------

Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>
(cherry picked from commit 9b5c6ed)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@dai-chen dai-chen added backport 0.x Backport to 0.x branch (stable branch) and removed backport 0.x Backport to 0.x branch (stable branch) labels Nov 5, 2025
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 5, 2025
* Adding connection timeout override for 10 seconds

Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>

* chaining request config builder options

Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>

---------

Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>
(cherry picked from commit 9b5c6ed)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dai-chen pushed a commit that referenced this pull request Nov 5, 2025
* Adding connection timeout override for 10 seconds



* chaining request config builder options



---------


(cherry picked from commit 9b5c6ed)

Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 5, 2025
* Adding connection timeout override for 10 seconds

Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>

* chaining request config builder options

Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>

---------

Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>
(cherry picked from commit 9b5c6ed)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dai-chen pushed a commit that referenced this pull request Nov 5, 2025
* Adding connection timeout override for 10 seconds



* chaining request config builder options



---------


(cherry picked from commit 9b5c6ed)

Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 0.x Backport to 0.x branch (stable branch) backport 0.7 DataSource:OpenSearch enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants