Skip to content

Commit 84e09c2

Browse files
committed
fixes
Signed-off-by: Kai Huang <ahkcs@amazon.com>
1 parent ed6d208 commit 84e09c2

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

core/src/main/java/org/opensearch/sql/expression/function/udf/binning/MinspanBucketFunction.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
public class MinspanBucketFunction extends ImplementorUDF {
3939

4040
public MinspanBucketFunction() {
41-
super(new MinspanBucketImplementor(), NullPolicy.ANY);
41+
super(new MinspanBucketImplementor(), NullPolicy.NONE);
4242
}
4343

4444
@Override

core/src/main/java/org/opensearch/sql/expression/function/udf/binning/RangeBucketFunction.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
public class RangeBucketFunction extends ImplementorUDF {
4343

4444
public RangeBucketFunction() {
45-
super(new RangeBucketImplementor(), NullPolicy.ANY);
45+
super(new RangeBucketImplementor(), NullPolicy.NONE);
4646
}
4747

4848
@Override

core/src/main/java/org/opensearch/sql/expression/function/udf/binning/SpanBucketFunction.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
public class SpanBucketFunction extends ImplementorUDF {
3737

3838
public SpanBucketFunction() {
39-
super(new SpanBucketImplementor(), NullPolicy.ANY);
39+
super(new SpanBucketImplementor(), NullPolicy.NONE);
4040
}
4141

4242
@Override

core/src/main/java/org/opensearch/sql/expression/function/udf/binning/WidthBucketFunction.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
public class WidthBucketFunction extends ImplementorUDF {
4444

4545
public WidthBucketFunction() {
46-
super(new WidthBucketImplementor(), NullPolicy.ANY);
46+
super(new WidthBucketImplementor(), NullPolicy.NONE);
4747
}
4848

4949
@Override

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteBinCommandIT.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1076,13 +1076,13 @@ public void testBinOnNonNumericStringField() {
10761076
assertThrows(
10771077
ResponseException.class,
10781078
() -> {
1079-
executeQuery(
1080-
String.format("source=%s | bin firstname bins=3 | head 1", TEST_INDEX_ACCOUNT));
1079+
executeQuery(String.format("source=%s | bin firstname bins=3", TEST_INDEX_ACCOUNT));
10811080
});
10821081

1082+
// Verify the error message contains information about non-numeric string values
10831083
String errorMessage = exception.getMessage();
10841084
assertTrue(
1085-
"Error should indicate non-numeric string values",
1085+
"Error message should indicate non-numeric string values: " + errorMessage,
10861086
errorMessage.contains("non-numeric string values"));
10871087
}
10881088
}

0 commit comments

Comments
 (0)