Skip to content

Move aks jobs to their own platform to differentiate from standard azure #2912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move aks jobs to their own platform to differentiate from standard azure #2912

wants to merge 1 commit into from

Conversation

dgoodwin
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot requested review from sosiouxme and stbenjam August 29, 2025 17:46
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 29, 2025

@dgoodwin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit ab5509a link true /test unit
ci/prow/security ab5509a link true /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@neisw
Copy link
Contributor

neisw commented Aug 29, 2025

/hold

hypershift is platform:aws, topology:external which is how aks is setup, platform:azure, topology:external

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2025
neisw
neisw reviewed Aug 29, 2025
View reviewed changes
pkg/variantregistry/ocp.go
{"-rosa", "rosa"}, // Keep above AWS as many ROSA jobs also mention AWS
{"-aws", "aws"},
{"-alibaba", "alibaba"},
{"-azure-aro-hcp", "aro"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look here for ARO, are you sure all AKS is ARO?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sosiouxme sosiouxme Awaiting requested review from sosiouxme

@stbenjam stbenjam Awaiting requested review from stbenjam

1 more reviewer

@neisw neisw neisw left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dgoodwin @neisw