Preserve rates as ints rather than doubles to make header parsing robust#1346
Open
aymanhab wants to merge 1 commit into
Open
Preserve rates as ints rather than doubles to make header parsing robust#1346aymanhab wants to merge 1 commit into
aymanhab wants to merge 1 commit into
Conversation
aymanhab
changed the title
Member
|
Is it possible that any of these values can take non-integer values? Or do they get converted to ints when passed to the MarkerData class? Otherwise, LGTM. |
Member
Author
|
@nickbianco In practice I've never seen rates that are non-ints, the MarkerData class uses doubles internally but reads/prints using custom simmIO class that's likely not robust and the long term plan should be to retire it altogether. |
Member
|
Okay, sounds good. Seems like this a find stop-gap solution until replace the simmIO class later. |
Member
Author
Agreed, will wait on more testing before merging. Thanks again @nickbianco |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #1344
Brief summary of changes
Write frameRate, cameraRate etc. as ints to avoid confusing the parser built into MarkerData class (GUI doesn't have its own parser). Ideally we switch to the TimeSeriesTable to avoid duplicity but those need work to be usable by the GUI.
Testing I've completed
Tested workflow suggested in issue and it all worked.
CHANGELOG.md (choose one)