Skip to content

Conversation

aymanhab
Copy link
Member

Fixes issue #<issue_number>

Brief summary of changes

Testing I've completed

CHANGELOG.md (choose one)

  • no need to update because internal

@aymanhab aymanhab requested a review from Copilot August 15, 2025 06:32
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request addresses bindings updates to align the Java GUI interface with underlying C++ library changes. The changes involve removing deprecated or obsolete functionality, updating method signatures, and adding new features.

  • Removed deprecated Manager integrator methods and replaced with new API
  • Added new properties to XsensDataReaderSettings and enhanced detection capabilities
  • Removed several wrap obstacle classes (WrapCylinderObst, WrapSphereObst, WrapDoubleCylinderObst)

Reviewed Changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
ForwardToolModel.java Removed getUseSpecifiedDt/setUseSpecifiedDt methods
opensimSimulationJNI.java Updated Manager native method bindings, removed wrap obstacle methods
opensimCommonJNI.java Added new native methods for delimiter detection and BoolLike class
opensimCommon.java Added detectDelimiter utility method
Manager.java Comprehensive Manager class API update with new integrator methods
XsensDataReaderSettings.java Added trial_extension and sampling_rate properties
TableMissingHeader.java Added constructor overload
StaticOptimization.java Added getStatesDerivativeStore method

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

* <br>
* Note: Supports single-character delimiters.<br>
* <br>
*
Copy link
Preview

Copilot AI Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation mentions 'single-character delimiters' but the method signature accepts a vector of delimiter strings. This could be confusing - consider clarifying whether multi-character delimiters are supported or if this limitation applies only to the implementation.

Suggested change
*
* <b>Note:</b> Only single-character delimiters are supported.<br>
* If a delimiter string contains more than one character,<br>
* only the first character will be considered.<br>
* <br>
* @return : The most likely delimiter (as an std::string),<br>
* or an empty string if none was found.<br>
* <br>

Copilot uses AI. Check for mistakes.

@aymanhab aymanhab merged commit a3d8a26 into main Aug 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants