-
Notifications
You must be signed in to change notification settings - Fork 199
Added automated schema to md generation #792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/validate b4f2701 |
Validation Results⛔ Found 1 errors ⛔ commit Overview0xbfbaa134ed5da64eca6b6fd39c04b273b6bb600d
0xe4666f0937b62d64c10316db0b7061549f87e95f
0x0ed37f546c7b70cd787eee94a521f24cd6653442
0xb45913337aca4988b08a61388c25e48ba5f6227c
0xb5087f95643a9a4069471a28d32c569d9bd57fe4
https://defillama.com/protocol/timeless-finance
https://defillama.com/protocol/bunni
https://defillama.com/protocol/fluid
|
|
||
### Arrays | ||
|
||
* [Untitled array in Blockchain address](./blockchain-address-properties-tags.md) – `blockchain-address.json#/properties/tags` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrm Untitled array
is maybe not the most useful. I'm not sure that having Arrays
as a top level item is generally useful either. I think we should instead only document the objects inside the array if they're object types and not any built in type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something we could change in jsonschema2md?
I don't think there is anything more A script can be created to remove the generated array schema readme, but removing it from the base README can't seem to be automated. However, I think custom scripts can be made to do the job if only a fixed types of tags are used. |
These markdown files are not very useful right now, considering most fields are either "Untitled" or "Unknown". |
I can make a custom python script to create the required kind of readme for schemas if I am given some specifications. But opening a separate issue will be better to adhere to the topics of the issues and PRs. |
Added a pnpm script
schema2md
which generates.md
files for all schemas insrc/resources/schema
and outputs them insrc/resources/schema2md
.