Skip to content

Update README.md: checkin -> checkinSync #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025
Merged

Update README.md: checkin -> checkinSync #1

merged 1 commit into from
Jul 31, 2025

Conversation

aothms
Copy link
Member

@aothms aothms commented Jul 20, 2025

No description provided.

@hlg
Copy link
Member

hlg commented Jul 31, 2025

Yes, indeed, that is still the 1.4 heritage. No idea why this could go unnoticed - I had been using the client a bit few years ago. Two more changes once you are there: The sync argument can be removed as the parameter kind of moved to the method name. The boolean values should actually be boolean (Python syntax False). Actually the Java webservice implementation might do the magic of converting strings to the expected type, but I would rather have the samples not rely on that, but use proper typing for the sake of clarity. I think in the Console app, there are also strings used where booleans (JSON syntax false) would be cleaner.

@hlg hlg merged commit a01a267 into master Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants