directionalCombo: handle [key]=left|right|both schema
#10935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft to resolve #10839
Following what was done in https://github.com/openstreetmap/iD/pull/9587/files
The UI part is done as far as I can see. When I test the code the tags and fields update as expected.
There is one gotcha that when updating one side of
cycleway=bothvia the UI, thebothvalues gets move to the "other" side. That is wrong but I think OK since users will see it and update the value right after the first change.If we wanted to improve this, we would need to give the
updatemethod access to the "other side value" or something like this.Test specs, however, don't work. They still expect the value to be the original input. I don't quite understand what is going on. Why do the changes I apply in the
directionalCombo.tagsnot show in the specs?todos