feat: Add Policy Protobufs #268
Conversation
|
| & OneOf<{ scope: ResourceAttribute }> | ||
|
|
||
| export type EntityEntitlements = { | ||
| entityId?: string |
There was a problem hiding this comment.
Unfortunately, it seems that this package marks every field as optional when generating code.
There is a very old / stale issue on this which doesn't appear to have any progress in the last two years: grpc-ecosystem/protoc-gen-grpc-gateway-ts#26
Is this a dealbreaker for us using protoc-gen-grpc-gateway-ts @strantalis?
There was a problem hiding this comment.
Also getting the following error message when building the protos:
Warning: plugin "grpc-gateway-ts" does not support required features.
Feature "proto3 optional" is required by 1 file(s):
authorization/authorization.proto
Pretty new to all this protobuf stuff so wondering if this is something that's easily fixed by adding another plugin? Or is it more complicated than that
There was a problem hiding this comment.
I'm kinda surprised optional is a feature of proto3. I've been outta the loop. https://stackoverflow.com/a/62566052/23894185
dmihalcik-virtru
left a comment
dmihalcik-virtru
left a comment
There was a problem hiding this comment.
I'd assumed we'd be going through REST via our Swagger json using something like openapi-typescript, but this generated code seems like it might be better? plus it is likely more performant
| & OneOf<{ scope: ResourceAttribute }> | ||
|
|
||
| export type EntityEntitlements = { | ||
| entityId?: string |
There was a problem hiding this comment.
I'm kinda surprised optional is a feature of proto3. I've been outta the loop. https://stackoverflow.com/a/62566052/23894185
No description provided.