-
Notifications
You must be signed in to change notification settings - Fork 419
[v10] Root claim/ Airdrop mechanism implementation
#3117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # tests/e2e_tests/utils/e2e_test_utils.py
Root claim/ Airdrop mechanism implementationRoot claim/ Airdrop mechanism implementation
thewhaleking
requested changes
Oct 30, 2025
Contributor
thewhaleking
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good. Couple needed fixes, couple suggestions (not required).
thewhaleking
approved these changes
Oct 31, 2025
ibraheem-abe
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New subtensor methods:
get_root_claim_typeget_root_claimable_rateget_root_claimable_all_ratesget_root_claimable_stakeget_root_claimedclaim_rootset_root_claim_typeNew extrinsics:
set_root_claim_type_extrinsicclaim_root_extrinsicThe functionality is fully implemented, but to pass the e2e tests PR requires:
NumRootClaimfrom1to0in thesudo_set_num_root_claimsfunction to avoid flaky test behavior (Root claim subtensor#2053 (comment))Based subtensor PR: opentensor/subtensor#2053
Bittensor issue: #3113
@MichaelTrestman when the
subtensor:devnet-readyis updated with the mentioned PRs and I update the description, please update the SDKv10 Migration Guide documentation with new Root claim feature. Thank you!