chore: sync 3.21.0 to dev 250208 #2871

kagol · 2025-02-08T06:28:32Z

PR

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our Commit Message Guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

Summary by CodeRabbit

Chores
- Upgraded package versions to 3.21.2.
- Improved the automated release process for consistent version derivation.
Style
- Refined popover and tooltip styling for a more uniform visual experience.
Refactor
- Streamlined grid component scrolling and layout adjustments to enhance responsiveness and performance.

* fix: [grid] fix footer bug in visual scroll scene * test: fix e2e test case

coderabbitai · 2025-02-08T06:28:39Z

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request updates the workflow and several package components. In the GitHub workflow, the branchVersion is now computed by splitting the tag string and appending “.0”. Version numbers in multiple package.json files have been bumped from 3.21.1 to 3.21.2. The CSS for popover components is simplified by eliminating conditional selectors. In grid components, scroll synchronization is refactored to reduce redundancy and improve event handling, while grid table methods are updated to reorder callback calls and enhance layout logic by adding an extra parameter.

Changes

File(s)	Summary
.github/…/auto-all-publish.yml	Modified `branchVersion` derivation from tag to ".0"
packages/theme/package.json, packages/vue/package.json, packages/vue/…/src/grid/package.json	Bumped version from `3.21.1` to `3.21.2`
packages/theme/src/base/reset.less	Removed conditional selectors for popover components; applied `.popper__arrow` styles unconditionally
packages/vue/src/grid/src/body/body.tsx	Refactored `syncHeaderAndFooterScroll` to use a local `scrollLeft` variable and moved scroll event binding into `render`
packages/vue/src/grid/src/table/src/methods.ts, packages/vue/src/grid/src/table/src/utils/updateStyle.ts	Changed callback order (updateFooter before updateStyle) and added `elemStore` parameter for footer layout management

Sequence Diagram(s)

sequenceDiagram
    participant Body as Body Element
    participant Grid as Grid Component
    participant Header as Header Element
    participant Footer as Footer Element

    Body->>Grid: Trigger scroll event
    Grid->>Grid: Read and store scrollLeft
    Grid->>Header: Update scrollLeft property
    Grid->>Footer: Update scrollLeft property

sequenceDiagram
    participant Table as Grid Table
    participant NextTick as DOM NextTick
    participant Footer as Footer Update
    participant Style as Style Update

    Table->>NextTick: Schedule update
    NextTick->>Footer: Call updateFooter()
    NextTick->>Style: Call updateStyle()

Possibly related PRs

ci(workflows): add utils package build and release automation process #2838: The changes in the main PR regarding the branchVersion derivation in the .github/workflows/auto-all-publish.yml file are related to the modifications in the retrieved PR that also involve changes to the same workflow file, specifically in the context of build and publish automation processes.
ci(workflows): support automated patch version tag #2773: The changes in the main PR modify the branchVersion derivation in the same workflow file as the retrieved PR, indicating a direct relationship in how versioning is handled.
fix(grid): [grid] fix footer bug in visual scroll scene #2839: The changes in the main PR are directly related to the modifications in the syncHeaderAndFooterScroll function and the updateScrollXData method in the retrieved PR, as both involve enhancements to scroll synchronization and rendering logic for the grid component.

Suggested reviewers

zzcr

Poem

Hoppin’ through the code with cheer,
Branch versions now end with “.0” clear.
Bumped versions and CSS refined,
Grid scrolls and layouts now aligned.
I nibble carrots while I debug the show,
A rabbit’s joy as our improvements grow!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4e4784a and eb97c47.

📒 Files selected for processing (8)

.github/workflows/auto-all-publish.yml (1 hunks)
packages/theme/package.json (2 hunks)
packages/theme/src/base/reset.less (2 hunks)
packages/vue/package.json (2 hunks)
packages/vue/src/grid/package.json (1 hunks)
packages/vue/src/grid/src/body/src/body.tsx (2 hunks)
packages/vue/src/grid/src/table/src/methods.ts (1 hunks)
packages/vue/src/grid/src/table/src/utils/updateStyle.ts (3 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

petercat-assistant · 2025-02-08T06:28:53Z

Walkthrough

This pull request synchronizes changes from version 3.21.0 to the development branch. It includes updates to configuration files, package dependencies, and styling adjustments. Key changes involve the handling of scroll events and layout updates in the Vue grid components.

Changes

Files	Summary
.github/workflows/auto-all-publish.yml	Minor updates to workflow configuration.
packages/theme/package.json	Updated package dependencies.
packages/vue/package.json	Updated package dependencies.
packages/vue/src/grid/package.json	Updated package dependencies.
packages/theme/src/base/reset.less	Adjusted CSS selectors for popper elements.
packages/vue/src/grid/src/body/src/body.tsx	Refactored scroll event handling and synchronization logic.
packages/vue/src/grid/src/table/src/methods.ts	Modified Vue rendering triggers and style updates.
packages/vue/src/grid/src/table/src/utils/updateStyle.ts	Added logic for footer layout adjustments.

petercat-assistant · 2025-02-08T06:28:55Z

packages/vue/src/grid/src/body/src/body.tsx

+        class: ['tiny-grid__body-wrapper', 'body__wrapper', { [classMap.isScrollload]: scrollLoad }],
+        on: {
+          scroll: this.scrollEvent
+        }


Ensure that the scroll event is properly debounced or throttled to prevent performance issues during rapid scrolling.

github-actions · 2025-02-08T06:29:06Z

[e2e-test-warn]
The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide

zzcr and others added 4 commits February 8, 2025 11:25

fix: fix all publish action run error (#2798)

c78b420

fix(tooltip): remove :has selector on arrow (#2830)

e7bff81

fix(grid): [grid] fix footer bug in visual scroll scene (#2839)

b72cbcd

* fix: [grid] fix footer bug in visual scroll scene * test: fix e2e test case

chore: update @opentiny/vue version

eb97c47

github-actions bot added the chore label Feb 8, 2025

petercat-assistant bot reviewed Feb 8, 2025

View reviewed changes

kagol merged commit 2d58a58 into dev Feb 8, 2025
6 checks passed

coderabbitai bot mentioned this pull request Mar 17, 2025

fix(popper): [tooltip,popover] fix popper doms in custom element, cant get zindex #3125

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: sync 3.21.0 to dev 250208 #2871

chore: sync 3.21.0 to dev 250208 #2871

kagol commented Feb 8, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 8, 2025 •

edited

Loading

Review failed

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

petercat-assistant bot commented Feb 8, 2025

petercat-assistant bot Feb 8, 2025

github-actions bot commented Feb 8, 2025

chore: sync 3.21.0 to dev 250208 #2871

chore: sync 3.21.0 to dev 250208 #2871

Conversation

kagol commented Feb 8, 2025 • edited by coderabbitai bot Loading

PR

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Summary by CodeRabbit

coderabbitai bot commented Feb 8, 2025 • edited Loading

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

petercat-assistant bot commented Feb 8, 2025

Walkthrough

Changes

petercat-assistant bot Feb 8, 2025

Choose a reason for hiding this comment

github-actions bot commented Feb 8, 2025

kagol commented Feb 8, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 8, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)