Skip to content

fix: Fix the title line height of mobile first steps #3385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025
Merged

Conversation

chenxi-20
Copy link
Collaborator

@chenxi-20 chenxi-20 commented May 6, 2025

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Style
    • Updated the medium title font style to include improved line-height for better text readability.

@chenxi-20 chenxi-20 added the bug Something isn't working label May 6, 2025
Copy link

coderabbitai bot commented May 6, 2025

Walkthrough

The update modifies the title-font-medium property within the classes object by adding the leading-5.5 CSS utility class alongside text-sm. No other class definitions or logic are changed, and there are no alterations to exported or public entity declarations.

Changes

File Path Change Summary
packages/vue/src/steps/src/mobile-first/token/normal-token.ts Added leading-5.5 to title-font-medium class string.

Poem

A sprinkle of style, a dash of delight,
Line heights adjusted, everything just right.
With leading-5.5, the titles now sing,
In the CSS meadow, new classes take wing.
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/vue/src/steps/src/mobile-first/token/normal-token.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-vue".

(The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-vue@latest --save-dev

The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between db1be9e and 79c18ff.

📒 Files selected for processing (1)
  • packages/vue/src/steps/src/mobile-first/token/normal-token.ts (1 hunks)
🔇 Additional comments (1)
packages/vue/src/steps/src/mobile-first/token/normal-token.ts (1)

32-32:

✅ Verification successful

Verify availability of leading-5.5 CSS utility class
Ensure that leading-5.5 is defined in your Tailwind (or CSS-in-JS) configuration to prevent build errors and match the design specification. This also keeps it consistent with the steps-title implementation on line 29.

Please run the following script to confirm:


🏁 Script executed:

#!/bin/bash
# Verify that `leading-5.5` is defined in the Tailwind config
rg -n "5\\.5" tailwind.config.js

Length of output: 92


🏁 Script executed:

#!/bin/bash
# Locate Tailwind config file(s)
echo "🔍 Locating Tailwind config files..."
find . -type f -name "tailwind.config.*"

# If any config files are found, search them for `5.5` or custom line-height entries
echo -e "\n🔍 Searching for '5.5' or 'lineHeight' definitions in config:"
find . -type f -name "tailwind.config.*" -exec rg -n "5\\.5|lineHeight" {} +

Length of output: 626


🏁 Script executed:

#!/bin/bash
# Show context around the lineHeight reference in the Tailwind config
echo "---- packages/theme-saas/tailwind.config.js (first 200 lines) ----"
sed -n '1,200p' packages/theme-saas/tailwind.config.js

Length of output: 3123


🏁 Script executed:

#!/bin/bash
# Inspect the lineHeight definitions in the design tokens
echo "---- layout.lineHeight in packages/theme-saas/theme/theme.json ----"
jq '.layout.lineHeight' packages/theme-saas/theme/theme.json

# Search explicitly for a "5.5" key in the JSON
echo -e "\n---- Searching for '\"5.5\"' in theme.json ----"
rg -n '"5\\.5"' packages/theme-saas/theme/theme.json

# Review how loadLayout consumes lineHeight tokens
echo -e "\n---- packages/theme-saas/plugins/loadTheme.js (first 200 lines) ----"
sed -n '1,200p' packages/theme-saas/plugins/loadTheme.js

Length of output: 5331


🏁 Script executed:

#!/bin/bash
# Inspect baseLayout.textLayout.lineHeight tokens
echo "---- baseLayout.textLayout.lineHeight tokens ----"
jq '.baseLayout.textLayout.lineHeight' packages/theme-saas/theme/theme.json

echo -e "\n---- baseLayout lineHeight keys ----"
jq '.baseLayout.textLayout.lineHeight | keys' packages/theme-saas/theme/theme.json

# Inspect themeColor[0].data.layout.textLayout.lineHeight tokens (if present)
echo -e "\n---- themeColor[0].data.layout.textLayout.lineHeight tokens ----"
jq '.themeColor[0].data.layout.textLayout.lineHeight' packages/theme-saas/theme/theme.json || echo "No themeColor[0].data.layout.textLayout.lineHeight"

echo -e "\n---- theme layout lineHeight keys ----"
jq '.themeColor[0].data.layout.textLayout.lineHeight | keys' packages/theme-saas/theme/theme.json || echo "No keys in themeColor layout"

Length of output: 1578


Verified availability of leading-5.5
No action needed—your Tailwind config already includes a 5.5 line-height token, so the leading-5.5 utility will be generated.

• packages/theme-saas/theme/theme.json: baseLayout.textLayout.lineHeight contains --tiny-lineHeight-5_5
• packages/theme-saas/plugins/loadTheme.js: maps --tiny-lineHeight-5_5 to the 5.5 key
• packages/theme-saas/tailwind.config.js: theme.lineHeight is set to layoutToken.lineHeight

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Walkthrough

This pull request addresses a styling issue by adjusting the line height for the 'title-font-medium' class in the mobile-first steps component. The change ensures consistent visual appearance across different devices.

Changes

File Summary
packages/vue/src/steps/src/mobile-first/token/normal-token.ts Adjusted 'title-font-medium' class to include 'leading-5.5' for consistent line height.

@@ -29,7 +29,7 @@ export const classes = {
'steps-title': 'hidden sm:block text-sm ml-2 font-medium truncate leading-5.5',
'title-font-mini': 'text-xs',
'title-font-small': 'text-xs',
'title-font-medium': 'text-sm',
'title-font-medium': 'text-sm leading-5.5',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line height for 'title-font-medium' has been adjusted to 'leading-5.5'. Ensure this change does not affect other components that rely on this class.

@zzcr zzcr merged commit 0617fdb into dev May 7, 2025
11 checks passed
@zzcr zzcr deleted the fix/steps-20250506 branch May 7, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants