fix(popper): [tooltip,popover] enhance the isScrollElement function to add judgment on element type and scroll bar #3411
Conversation
WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant isScrollElement
participant Element
Caller->>isScrollElement: Call with Element
isScrollElement->>isScrollElement: Check if Element is valid and element node
alt Invalid Element
isScrollElement-->>Caller: Return false
else Valid Element
isScrollElement->>Element: Get computed styles (overflow, overflow-x, overflow-y)
isScrollElement->>isScrollElement: Test overflow properties with regex
isScrollElement->>Element: Compare scrollHeight/clientHeight and scrollWidth/clientWidth
alt Overflow matches and content is scrollable
isScrollElement-->>Caller: Return true
else
isScrollElement-->>Caller: Return false
end
end
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
packages/utils/src/popper/index.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThe PR enhances the Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| @@ -99,13 +99,19 @@ const getBoundingClientRect = (el: HTMLElement) => { | |||
|
|
|||
| /** 判断el的overflow是不是可能滚动的 */ | |||
| const isScrollElement = (el: HTMLElement) => { | |||
| const scrollTypes = ['scroll', 'auto'] | |||
| if (!el || el.nodeType !== 1) { | |||
There was a problem hiding this comment.
Ensure that the element is a valid node before proceeding with overflow checks. This prevents errors when el is null or not an element node.
zzcr
changed the title
fix(popper): 增强isScrollElement函数，增加对元素类型和滚动条的判断
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit