fix(popeditor): add three slot to popeditor #3416
Conversation
WalkthroughThree new named slots— Changes
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
examples/sites/demos/apis/popeditor.jsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. packages/vue/src/popeditor/src/pc.vueOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
examples/sites/demos/apis/popeditor.js (1)
447-476: Provide English Descriptions & Demo References for New SlotsThe new slots
title-selection,title-history, andtitle-sourceare documented, but their English descriptions and example demo links (pcDemo) are left blank. To improve clarity and consistency with other documented slots, please add meaningful English descriptions and point to the relevant demo sections. For instance:{ name: 'title-selection', defaultValue: '', - desc: { - 'zh-CN': '已选择数据标题插槽', - 'en-US': '' - }, + desc: { + 'zh-CN': '已选择数据标题插槽', + 'en-US': 'Title slot for selected data' + }, + pcDemo: 'slot-title-selection' }, { name: 'title-history', defaultValue: '', - desc: { - 'zh-CN': '历史数据标题插槽', - 'en-US': '' - }, + desc: { + 'zh-CN': '历史数据标题插槽', + 'en-US': 'Title slot for history data' + }, + pcDemo: 'slot-title-history' }, { name: 'title-source', defaultValue: '', - desc: { - 'zh-CN': '所有数据标题插槽', - 'en-US': '' - }, + desc: { + 'zh-CN': '所有数据标题插槽', + 'en-US': 'Title slot for all data' + }, + pcDemo: 'slot-title-source' },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
examples/sites/demos/apis/popeditor.js(1 hunks)packages/vue/src/popeditor/src/pc.vue(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (3)
packages/vue/src/popeditor/src/pc.vue (3)
154-156: Correctly Introducetitle-historySlotWrapping the static history tab title in
<slot name="title-history">with the original<span>{{ t('ui.popeditor.historyLists') }}</span>as fallback is spot-on. This enables consumers to customize the history tab label without breaking defaults.
164-166: Correctly Introducetitle-sourceSlotThe
title-sourceslot replaces the hard-coded source tab title, retaining<span>{{ t('ui.popeditor.sourceLists') }}</span>as fallback. This matches the PR objective and follows best practices for slot usage.
234-236: Correctly Introducetitle-selectionSlotAdding the
title-selectionslot around the selection tab title with fallback<span>{{ t('ui.popeditor.selectionLists') }}</span>is implemented cleanly. Consumers can now override the selected-data tab label.
PR
参考A源码， 补充3个缺失的插槽
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit