Skip to content

fix(date-picker):Fix the e2e test #3430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged

fix(date-picker):Fix the e2e test #3430

merged 1 commit into from
May 15, 2025

Conversation

discreted66
Copy link
Collaborator

@discreted66 discreted66 commented May 15, 2025

PR

修复时间区间e2e测试用例

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Style

    • Updated date range picker styles to apply width only when specific panel classes are present, improving style scoping and maintainability.
  • Tests

    • Streamlined and enhanced date-time range selection tests for improved reliability and accuracy, including updated input interactions and expected values.

Copy link

coderabbitai bot commented May 15, 2025

Walkthrough

The updates include revisions to a date range picker test to refine interaction steps, selectors, and expected values, as well as modifications to the LESS stylesheet for the date range picker component, introducing a CSS class prefix variable and adjusting selector scoping for width styling.

Changes

File(s) Change Summary
examples/sites/demos/pc/app/date-picker/date-range.spec.ts Updated test to set viewport size, revised selectors for date-time range interactions, streamlined click sequences, removed redundant waits, and changed expected assertion values to match the originally filled dates and times.
packages/theme/src/date-range/index.less Introduced a LESS variable for a CSS class prefix, adjusted selectors to use this variable, and scoped the width rule to apply only when both date range picker and picker panel classes are present. No public API changes.

Poem

In the garden of dates and time,
A rabbit tweaks the code—sublime!
Selectors pruned, assertions neat,
LESS now styles with extra beat.
From test to theme, a gentle sweep,
The range picker bounds now leap!
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

examples/sites/demos/pc/app/date-picker/date-range.spec.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-vue".

(The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-vue@latest --save-dev

The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 57a12c8 and 23ae30b.

📒 Files selected for processing (2)
  • examples/sites/demos/pc/app/date-picker/date-range.spec.ts (2 hunks)
  • packages/theme/src/date-range/index.less (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (7)
packages/theme/src/date-range/index.less (2)

18-18: Good addition of a reusable variable for the picker panel class prefix.

Adding this variable improves maintainability by centralizing the definition of the picker panel class prefix, which can be reused throughout the stylesheet.


20-25: Improved selector specificity with better scoped width rule.

The restructuring of selectors is a good improvement. By nesting the width property under the combined selector (when both date-range-picker and picker-panel classes are present), the styling becomes more targeted and less likely to cause unintended side effects on other elements.

This change correlates with the test updates in the spec file and should help ensure consistent styling across different component states.

examples/sites/demos/pc/app/date-picker/date-range.spec.ts (5)

3-5: Good addition of explicit viewport settings.

Setting a fixed viewport size (1920x1080) is a best practice for e2e tests as it ensures consistent test behavior across different environments and CI systems.


46-46: Simplified selector for better test stability.

Simplifying the selector to li:nth-child(2) makes the test more robust by using a simpler, more direct DOM traversal path. This change aligns with the CSS restructuring in the date-range component.


54-54: Updated selector to match component structure changes.

The updated selector for the time spinner reflects changes in the component's DOM structure, ensuring test compatibility with the revised component implementation.


59-59: Added focus click for improved interaction reliability.

Adding an explicit click on the start date time input before pressing Enter helps ensure proper focus management, which can prevent flaky test failures.


61-63: Fixed assertions to match expected component behavior.

The test now correctly expects the originally entered values ('2023-05-20 08:00:00' and '2023-06-20 18:00:00') rather than altered values. This suggests either:

  1. A fix to the component's behavior to maintain user-entered values, or
  2. A correction to the test to properly validate the expected behavior

This change is key to fixing the e2e test mentioned in the PR objective.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the bug Something isn't working label May 15, 2025
Copy link

Walkthrough

此PR修复了时间区间选择器的e2e测试用例,主要通过调整测试脚本和样式文件来确保测试的准确性和稳定性。

Changes

文件 概要
examples/sites/demos/pc/app/date-picker/date-range.spec.ts 修改了e2e测试脚本,调整了元素选择器和交互步骤,以提高测试的准确性。
packages/theme/src/date-range/index.less 调整了样式文件,修改了CSS类的结构以适应新的样式需求。

@@ -40,26 +43,24 @@ test('测试日期范围选择', async ({ page }) => {
await page.getByRole('cell', { name: '10' }).nth(1).click()
await page.waitForTimeout(100)
await page.getByRole('textbox', { name: '开始时间' }).click()
await page.locator('li:nth-child(2)').first().click()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from li:nth-child(2) > span to li:nth-child(2) could potentially alter the intended element interaction. Ensure that this change aligns with the desired functionality and does not introduce unexpected behavior.

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


Walkthrough

This PR fixes the e2e test case of the time interval selector, mainly by adjusting the test scripts and style files to ensure the accuracy and stability of the test.

Changes

Documents Summary
examples/sites/demos/pc/app/date-picker/date-range.spec.ts Modified the e2e test script, adjust the element selector and interaction steps to improve the accuracy of the test.
packages/theme/src/date-range/index.less The style file has been adjusted and the structure of the CSS class has been modified to meet the new style requirements.

@zzcr zzcr merged commit 9291100 into opentiny:dev May 15, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants