-
Notifications
You must be signed in to change notification settings - Fork 308
fix(icon):Fixed the icon color issue in dark mode #3460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (6)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Walkthrough修复暗色模式下图标颜色问题,涉及多个SVG文件的修改,以确保在暗色模式下图标显示正确。 Changes
|
@@ -1,20 +1,10 @@ | |||
<svg width="16.000000" height="16.000000" viewBox="0 0 16 16" fill="none" | |||
xmlns="http://www.w3.org/2000/svg" | |||
<svg width="12.998291" height="13.000000" viewBox="0 0 12.9983 13" fill="none" xmlns="http://www.w3.org/2000/svg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the changes to the SVG files do not introduce any rendering issues in other themes or modes.
<path id="形状结合" d="M10.68 1.86C11.1 1.51 11.72 1.54 12.1 1.92L14.07 3.89C14.45 4.27 14.48 4.89 14.13 5.3L11.3 8.66L11.68 9.04C12.06 9.42 12.08 10.01 11.76 10.43L11.68 10.52L9.75 12.45C9.34 12.86 8.67 12.86 8.26 12.45L6.25 10.44L2.93 13.77C2.73 13.97 2.41 13.97 2.22 13.77C2.02 13.58 2.02 13.26 2.22 13.06L5.55 9.74L3.54 7.72C3.15 7.34 3.13 6.73 3.47 6.31L3.54 6.24L5.46 4.31C5.87 3.9 6.54 3.9 6.95 4.31L7.33 4.69L10.68 1.86ZM11.35 2.62L7.27 6.05L6.24 5.02C6.22 5 6.19 5 6.17 5.02L4.24 6.95C4.22 6.97 4.22 7 4.24 7.02L8.97 11.75C8.99 11.76 9.02 11.76 9.04 11.75L10.97 9.82C10.99 9.8 10.99 9.77 10.97 9.75L9.94 8.72L13.36 4.66C13.38 4.64 13.38 4.61 13.36 4.59L11.35 2.62Z" fill="#191919" fill-opacity="1.000000" fill-rule="nonzero"/> | ||
</g> | ||
</svg> | ||
<svg viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the changes to the SVG files do not introduce any rendering issues in other themes or modes.
@@ -1,15 +1,16 @@ | |||
<svg width="16.000000" height="16.000000" viewBox="0 0 16 16" fill="none" | |||
xmlns="http://www.w3.org/2000/svg" | |||
<svg width="16.000000" height="16.000000" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the changes to the SVG files do not introduce any rendering issues in other themes or modes.
@@ -1,15 +1,16 @@ | |||
<svg width="16.000000" height="16.000000" viewBox="0 0 16 16" fill="none" | |||
xmlns="http://www.w3.org/2000/svg" | |||
<svg width="16.000000" height="16.000000" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the changes to the SVG files do not introduce any rendering issues in other themes or modes.
@@ -1,20 +1,22 @@ | |||
<svg width="16.000000" height="16.000000" viewBox="0 0 16 16" fill="none" | |||
xmlns="http://www.w3.org/2000/svg" | |||
<svg width="16.000000" height="16.000000" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the changes to the SVG files do not introduce any rendering issues in other themes or modes.
@@ -1,15 +1,16 @@ | |||
<svg width="16.000000" height="16.000000" viewBox="0 0 16 16" fill="none" | |||
xmlns="http://www.w3.org/2000/svg" | |||
<svg width="16.000000" height="16.000000" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the changes to the SVG files do not introduce any rendering issues in other themes or modes.
PR
修复暗色模式下图标显示问题
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information