Skip to content

fix(tag): theme saas warning token value refresh, tag component style specification refresh #3463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2025

Conversation

wuyiping0628
Copy link
Collaborator

@wuyiping0628 wuyiping0628 commented May 27, 2025

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Style

    • Updated warning tag colors for improved visual consistency across light, dark, and plain themes.
    • Adjusted text, background, and border color mappings for warning tags to align with updated theme palette.
  • Chores

    • Refined theme color values for warning variants in both light and dark modes.

Copy link

coderabbitai bot commented May 27, 2025

Walkthrough

The updates revise color references for "warning" tag variants across style, theme, and token configuration files. Changes include updating color tokens and class mappings for warning tags in both light and dark modes, and modifying the color palette values in the theme JSON file. No structural or exported entity changes are introduced.

Changes

File(s) Change Summary
packages/theme-saas/src/tag/index.less Updated warning tag color tokens: switched to warning.bold, warning.subtle, warning.active, and adjusted text color.
packages/theme-saas/theme/theme.json Modified "warning" color palette: updated base, bold, and subtler color values in both light and dark modes.
packages/vue/src/tag/src/token.ts Changed warning variant class mappings: updated text, background, and border color classes for warning styles.

Poem

In the meadow of tags, a warning hue,
Colors shift softly, a palette anew.
Bold and subtle, with borders refined,
The theme’s now brighter, perfectly aligned.
Rabbits rejoice in this color parade,
For every warning, a gentle upgrade! 🐇🌼

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/vue/src/tag/src/token.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-vue".

(The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-vue@latest --save-dev

The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1d1324d and dbef62f.

📒 Files selected for processing (3)
  • packages/theme-saas/src/tag/index.less (3 hunks)
  • packages/theme-saas/theme/theme.json (2 hunks)
  • packages/vue/src/tag/src/token.ts (4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (9)
packages/theme-saas/theme/theme.json (2)

120-127: Consistent update of warning token palette values

The color-warning, color-warning-bold, and color-warning-subtler entries in light mode have been updated to use the new yellow shades (yellow-500, yellow-800, yellow-50), aligning with the revised design spec.


560-567: Mirror warning color adjustments in dark mode

The same palette entries for warning colors are correctly updated in dark mode (yellow-500, yellow-800, yellow-50), ensuring consistency across both themes.

packages/theme-saas/src/tag/index.less (3)

74-82: Use warning.bold & warning.subtle for default warning variant

The normal warning tag now references warning.bold instead of warning.DEFAULT and uses warning.subtle instead of warning.subtler, matching the updated theme tokens.


132-138: Swap text.inverse for text.primary in dark-warning

The dark warning text color is updated to text.primary, improving readability against the dark background and aligning with the new token definitions.


194-202: Introduce warning.active in plain-warning variant

The plain warning variant now uses warning.active for the text color, replacing the subtler token to enhance contrast on a plain background.

packages/vue/src/tag/src/token.ts (4)

6-6: Dark-warning class text color updated

Changed from text-color-text-inverse to text-color-text-primary to reflect the updated dark-mode warning text token.


16-16: Light-warning uses warning-bold & warning-subtle tokens

Updated to text-color-warning-bold with bg-color-warning-subtle, syncing with the revised theme palette.


26-26: Plain-warning now uses warning-active

Text color class text-color-warning-active replaces the previous subtler shade, improving visibility in the plain variant.


36-36: Warning-border token updated

Border color token switched to border-color-warning, aligning with the updated default warning color token.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the bug Something isn't working label May 27, 2025
Copy link

Walkthrough

This PR updates the theme and style specifications for the tag component in the tiny-vue project. It primarily focuses on refreshing the warning token values and adjusting the style specifications to align with the updated theme settings.

Changes

Files Summary
packages/theme-saas/src/tag/index.less Updated theme color references for warning states to use new token values.
packages/theme-saas/theme/theme.json Adjusted theme configurations to reflect new warning color tokens.
packages/vue/src/tag/src/token.ts Modified class definitions to incorporate new warning color tokens.

@wuyiping0628 wuyiping0628 added enhancement New feature or request (功能增强) and removed bug Something isn't working labels May 27, 2025
@github-actions github-actions bot added bug Something isn't working and removed enhancement New feature or request (功能增强) labels May 27, 2025
@zzcr zzcr merged commit cfb7481 into dev May 27, 2025
13 of 26 checks passed
@zzcr zzcr deleted the wyp/token-0527 branch May 27, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants