UCS/DATASTRUCT: Interval tree fixes#11213
Open
shasson5 wants to merge 3 commits intoopenucx:masterfrom
Open
Conversation
yosefe
reviewed
Feb 26, 2026
src/ucs/datastruct/interval_tree.c
Outdated
| tree->root = ucs_interval_tree_insert_node(tree->root, new_node); | ||
|
|
||
| /* Update single_node flag: tree is single node if root has no children */ | ||
| tree->single_node = (tree->root->left == NULL) && |
Contributor
There was a problem hiding this comment.
maybe have tree->num_nodes and do ++ every time we insert to it and -- when remove?
src/ucs/datastruct/interval_tree.h
Outdated
Comment on lines
+30
to
+32
| ucs_interval_node_t *root; /**< Root node of the tree */ | ||
| ucs_mpool_t *mpool; /**< Memory pool for node allocation */ | ||
| int single_node; /**< Cached flag: 1 if tree has only root node */ |
yosefe
reviewed
Mar 1, 2026
yosefe
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Some fixes that were not included in first Interval tree PR
Why?
Improve several points: