Upgrade to Astro v5 and preact #1153
Conversation
lukewarlow
requested review from
gregwhitworth,
mfreed7 and
dbaron
as code owners
| @@ -6,7 +6,8 @@ const CONTRIBUTORS = []; | |||
| const fetchContributors = async (page) => { | |||
| const response = await fetch(`${CONTRIBUTORS_URL}?page=${page}`); | |||
| const contributors = await response.json(); | |||
| CONTRIBUTORS.push(...contributors); | |||
| if (Array.isArray(contributors)) | |||
There was a problem hiding this comment.
The home page crashes locally pretty quickly without this check, as GitHub API has rate limits.
lukewarlow
force-pushed
the
upgrade-astro5
branch
from
58a2397 to
4b8013a
Compare
|
I think this will need the netfliy nodejs version upgraded. |
This happens to improve the prefetch behaviour so that it only happens on link hover instead of on page load.
This reduces the size of the JS bundles.
lukewarlow
force-pushed
the
upgrade-astro5
branch
from
1ef8f50 to
cde89e3
Compare
…vokers polyfill and reduce navigation-container complexity
| <NavigationContainer client:load> | ||
| <NavigationContainer client:only> | ||
| <CommunityLinks className="mobile" /> |
There was a problem hiding this comment.
Does this mean the JS for CommunityLinks runs client-side too? It inlines a bunch of SVGs into JSX, definitely want to avoid having it in any client bundles.
There was a problem hiding this comment.
Good point will need to double check that.
There was a problem hiding this comment.
So there's 4 inlined SVGs into the JSX but that's the case anyway. Seems fine?
There was a problem hiding this comment.
Probably better off converting them into a sprite sheet & consuming with <use>.
Not that a few SVGs is the end of the world but that's objectively the most expensive way to use them & by a large margin too.
lukewarlow
force-pushed
the
upgrade-astro5
branch
from
f64b8ba to
db3b50f
Compare
This happens to improve the prefetch behaviour so that it only happens on link hover instead of on page load.