-
Notifications
You must be signed in to change notification settings - Fork 216
[WIP] graph pool #3114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
atobiszei
wants to merge
12
commits into
main
Choose a base branch
from
atobisze_check_graph_pool
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WIP] graph pool #3114
+1,563
−138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d9b6526
to
258ff5d
Compare
bc3a7f0
to
4523916
Compare
This reverts commit dddaf1b.
TODO: -> this requires additional patch in MP to reset initialized_ flag in CalculatorGraph and verify if that works. Previous MP tests with reruns worked due to using AddVectorSink which changes the underlying graph and does not use OutputStreamPollers. Need to verify if change in MP will enable graph pool or we need to go back to thread pool.
0777327
to
16c38da
Compare
TEST_FILTER="**:-*HttpRestApiHandlerTest*:*Metric*Infer*:*MetricFlow*RestV3*:*MetricFlo*Current*:*Stream*"; echo $TEST_FILTER; bazel test -c opt --test_timeout 393 --subcommands --runs_per_test=1 --test_filter=${TEST_FILTER} --jobs 111 --subcommands --config mp_on_py_on --experimental_ui_max_stdouterr_bytes=10485760 //src:ovms //src:ovms_test 2>&1 | tee log
[ FAILED ] 23 tests, listed below: [ FAILED ] MetricFlowTest.GrpcModelInfer [ FAILED ] MetricFlowTest.RestModelInfer [ FAILED ] MetricFlowTest.RestV3Unary [ FAILED ] MediapipeNegativeFrameworkTest.NoOutputPacketProduced [ FAILED ] HttpOpenAIHandlerTest.Unary [ FAILED ] HttpOpenAIHandlerTest.UnaryWithHeaders [ FAILED ] PythonFlowTest.PythonNodeFileDoesNotExist [ FAILED ] PythonFlowTest.PythonNodeClassDoesNotExist [ FAILED ] PythonFlowTest.PythonNodeExecuteNotImplemented [ FAILED ] PythonFlowTest.PythonNodeNameAlreadyExist [ FAILED ] PythonFlowTest.PythonNodeInitFailed [ FAILED ] PythonFlowTest.PythonNodeInitFailedImportOutsideTheClassError [ FAILED ] PythonFlowTest.PythonNodeInitException [ FAILED ] PythonFlowTest.PythonNodeOptionsMissing [ FAILED ] PythonFlowTest.PythonNodeNameMissing [ FAILED ] PythonFlowTest.PythonNodeNameDoesNotExist [ FAILED ] PythonFlowTest.PythonNodeInitMembers [ FAILED ] PythonFlowTest.PythonNodePassArgumentsToConstructor [ FAILED ] PythonFlowTest.PythonCalculatorTestSingleInSingleOutMultiRunWithErrors [ FAILED ] PythonFlowTest.Negative_NodeFiresProcessWithoutAllInputs [ FAILED ] PythonFlowTest.Positive_NodeFiresProcessWithoutAllInputs [ FAILED ] StreamingTest.SingleStreamSend1Receive3 [ FAILED ] StreamingTest.InvalidGraph TODO: * Improve WA with inserting MP graph definition * Give option to disable pool - this would most probably enable a lot of skipped tests from streaming, as they're not implemented with reusing graph in mind. * Cleanup
0db5de7
to
7cc0917
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary
JIRA/Issue if applicable.
Describe the changes.
🧪 Checklist
``